Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable incremental build for x-pack tests #78131

Merged
merged 2 commits into from
Sep 24, 2020
Merged

disable incremental build for x-pack tests #78131

merged 2 commits into from
Sep 24, 2020

Conversation

mshustov
Copy link
Contributor

x-pack/test/ type check is the bottleneck for node script/type_check due to incremental build usage. They are already disabled for x-pack due to significant overhead for the very first run. It makes sense to align x-pack/test with the "parent" folder because x-pack/test compilation includes all the code from the x-pack project as well.
type check with incremental: false ~ 1.5min
type check with incremental: true first run ~ 12min
type check with incremental: true second run ~ 2min

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov requested a review from a team September 22, 2020 13:27
@mshustov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 29bc00c into elastic:master Sep 24, 2020
@mshustov mshustov deleted the disable-incremental-xpack-test branch September 24, 2020 09:15
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78131 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 28, 2020
@mshustov mshustov mentioned this pull request Sep 28, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Sep 28, 2020
@mshustov @elasticmachine
disable incremental build for x-pack tests (elastic#78131)
8db2fe8 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 28, 2020
mshustov added a commit that referenced this pull request Sep 28, 2020
@mshustov @elasticmachine
disable incremental build for x-pack tests (#78131) (#78594)
d867236 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshustov @elasticmachine @kibanamachine @rudolf