[APM] Use model_plot as a signal for anomaly scores #77756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Sep 17, 2020
Comment on lines
56
to
58
| const lte = end; | ||
| // fetch data for at least 30 minutes | ||
| const gte = Math.min(end - 30 * 60 * 1000, start); |
There was a problem hiding this comment.
I think these would read better if they were inlined. A const named "lte" without context is pretty cryptic.
Comment on lines
154
to
157
| transactionType, | ||
| jobId, | ||
| actualValue: mlResult?.actual?.[0], | ||
| anomalyScore: mlResult?.record_score || 0, |
There was a problem hiding this comment.
nit: any reason some of these are inlined and others are not?
Suggested change
| transactionType, | |
| jobId, | |
| actualValue: mlResult?.actual?.[0], | |
| anomalyScore: mlResult?.record_score || 0, | |
| transactionType: mlResult?.job_id, | |
| jobId: mlResult?.by_field_value, | |
| actualValue: mlResult?.actual?.[0], | |
| anomalyScore: mlResult?.record_score || 0, |
sorenlouv
reviewed
Sep 18, 2020
| @@ -130,13 +143,15 @@ function transformResponseToServiceAnomalies( | |||
| response.aggregations?.services.buckets ?? [] | |||
| ).reduce( | |||
| (statsByServiceName, { key: serviceName, top_score: topScoreAgg }) => { | |||
| const mlResult = topScoreAgg.hits.hits[0]._source; | |||
There was a problem hiding this comment.
You had this as a maybe previously? Was that not the case?
(I like it better now for sure)
There was a problem hiding this comment.
It's always there, because we don't use min_doc_count: 0. So the maybe here was too defensive anyway.
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77083.
Before:
After:
