Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Fix date format autocomplete suggestions #76881

Merged
merged 6 commits into from
Sep 21, 2020
Merged

[Console] Fix date format autocomplete suggestions #76881

merged 6 commits into from
Sep 21, 2020

Conversation

jloleysens
Copy link
Contributor

Summary

Ensure Console suggests all options for properties.format inside a mappings object per https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html

@jloleysens jloleysens added Feature:Console Dev Tools Console Feature v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 7, 2020
@jloleysens jloleysens requested a review from a team as a code owner September 7, 2020 14:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links
Copy link
Contributor

Testing this.

@cuff-links
Copy link
Contributor

cuff-links commented Sep 10, 2020 •
edited
Loading

Hi, @jloleysens. I went through the whole list several times and I couldn't find strict_date_optional_time_nanos. Can you please verify if it's there on your end? And if it's not there, does it need to be?
Screen Shot 2020-09-10 at 7 22 28 PM

cuff-links
cuff-links suggested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see previous comment.

@cuff-links
Copy link
Contributor

I also noticed that the options are not in alphabetical order. I think that makes for a much better user experience.

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@cuff-links I believe I addressed your feedback. Great suggestion regarding alphabetical ordering!

cuff-links
cuff-links approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested.

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 9647330 into elastic:master Sep 21, 2020
@jloleysens jloleysens deleted the fix/console/mappings-date-format-autocomplete branch September 21, 2020 10:28
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 21, 2020
@jloleysens @elasticmachine
[Console] Fix date format autocomplete suggestions (elastic#76881)
90fe71a 
* fix date format autocomplete suggestions

* add missing completion and sort alphabetically

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jloleysens jloleysens mentioned this pull request Sep 21, 2020
Merged
jloleysens added a commit that referenced this pull request Sep 21, 2020
@jloleysens @elasticmachine
[Console] Fix date format autocomplete suggestions (#76881) (#77991)
5f95cea 
* fix date format autocomplete suggestions

* add missing completion and sort alphabetically

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@ywangd
Copy link
Member

ywangd commented Feb 27, 2021

@jloleysens This PR makes the suggestions for format appear inside an array, i.e. it was suggested as:

"format": [ "basic_date" ]

Above will result in an "IllegalArgumentException" on the ES side and the correct syntax should be as the follows:

"format": "basic_date"

This is also evident in the screenshot linked in the previous comment. It was correct in v7.9, but broken for 7.10 and 7.11. (didn't test for 7.12, but the issue should exist as well given there is no change to the file).

Any chance to fix it for 7.13? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuff-links cuff-links cuff-links approved these changes

Assignees
No one assigned
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jloleysens @elasticmachine @cuff-links @kibanamachine @ywangd @cjcenizal