Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove "Are you sure" from anomaly detection jobs #75931

Merged
merged 4 commits into from
Sep 1, 2020
Merged

[ML] Remove "Are you sure" from anomaly detection jobs #75931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62aef0f
Remove unnecessary job and rule text
lcawl Aug 28, 2020
fedfc59
Fixes test
lcawl Aug 28, 2020
8ea8626
[ML] Adds punctuation
lcawl Aug 31, 2020
23476b7
Merge branch 'master' into ml-text
elasticmachine Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions ...on/components/rule_editor/select_rule_action/__snapshots__/delete_rule_modal.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 2 additions & 9 deletions ...gins/ml/public/application/components/rule_editor/select_rule_action/delete_rule_modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class DeleteRuleModal extends Component {
title={
<FormattedMessage
id="xpack.ml.ruleEditor.deleteRuleModal.deleteRuleTitle"
defaultMessage="Delete rule"
defaultMessage="Delete rule?"
/>
}
onCancel={this.closeModal}
Expand All @@ -66,14 +66,7 @@ export class DeleteRuleModal extends Component {
/>
}
defaultFocusedButton={EUI_MODAL_CONFIRM_BUTTON}
>
<p>
<FormattedMessage
id="xpack.ml.ruleEditor.deleteRuleModal.deleteRuleDescription"
defaultMessage="Are you sure you want to delete this rule?"
/>
</p>
</EuiConfirmModal>
/>
</EuiOverlayMask>
);
}
Expand Down
13 changes: 2 additions & 11 deletions ...gins/ml/public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export class DeleteJobModal extends Component {
const title = (
<FormattedMessage
id="xpack.ml.jobsList.deleteJobModal.deleteJobsTitle"
defaultMessage="Delete {jobsCount, plural, one {{jobId}} other {# jobs}}"
defaultMessage="Delete {jobsCount, plural, one {{jobId}} other {# jobs}}?"
values={{
jobsCount: this.state.jobs.length,
jobId: this.state.jobs[0].id,
Expand Down Expand Up @@ -144,21 +144,12 @@ export class DeleteJobModal extends Component {

{this.state.deleting === false && (
<React.Fragment>
<p>
<FormattedMessage
id="xpack.ml.jobsList.deleteJobModal.deleteJobsDescription"
defaultMessage="Are you sure you want to delete {jobsCount, plural, one {this job} other {these jobs}}?"
values={{
jobsCount: this.state.jobs.length,
}}
/>
</p>
<p>
<FormattedMessage
id="xpack.ml.jobsList.deleteJobModal.deleteMultipleJobsDescription"
defaultMessage="Deleting {jobsCount, plural, one {a job} other {multiple jobs}} can be time consuming.
{jobsCount, plural, one {It} other {They}} will be deleted in the background
and may not disappear from the jobs list instantly"
and may not disappear from the jobs list instantly."
values={{
jobsCount: this.state.jobs.length,
}}
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11634,7 +11634,6 @@
"xpack.ml.jobsList.deleteJobModal.cancelButtonLabel": "キャンセル",
"xpack.ml.jobsList.deleteJobModal.closeButtonLabel": "閉じる",
"xpack.ml.jobsList.deleteJobModal.deleteButtonLabel": "削除",
"xpack.ml.jobsList.deleteJobModal.deleteJobsDescription": "{jobsCount, plural, one {このジョブ} other {これらのジョブ}}を削除してよろしいですか？",
"xpack.ml.jobsList.deleteJobModal.deleteJobsTitle": "{jobsCount, plural, one {{jobId}} other {# 件のジョブ}}を削除",
"xpack.ml.jobsList.deleteJobModal.deleteMultipleJobsDescription": "{jobsCount, plural, one {ジョブ} other {複数ジョブ}}の削除には時間がかかる場合があります。{jobsCount, plural, one {} other {}}バックグラウンドで削除され、ジョブリストからすぐに消えない場合があります",
"xpack.ml.jobsList.deleteJobModal.deletingJobsStatusLabel": "ジョブを削除中",
Expand Down Expand Up @@ -12303,7 +12302,6 @@
"xpack.ml.ruleEditor.deleteJobRule.ruleNoLongerExistsErrorMessage": "ジョブ {jobId} の検知器インデックス {detectorIndex} のルールが現在存在しません",
"xpack.ml.ruleEditor.deleteRuleModal.cancelButtonLabel": "キャンセル",
"xpack.ml.ruleEditor.deleteRuleModal.deleteButtonLabel": "削除",
"xpack.ml.ruleEditor.deleteRuleModal.deleteRuleDescription": "このルールを削除してよろしいですか？",
"xpack.ml.ruleEditor.deleteRuleModal.deleteRuleLinkText": "ルールを削除",
"xpack.ml.ruleEditor.deleteRuleModal.deleteRuleTitle": "ルールの削除",
"xpack.ml.ruleEditor.detectorDescriptionList.detectorTitle": "検知器",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11638,7 +11638,6 @@
"xpack.ml.jobsList.deleteJobModal.cancelButtonLabel": "取消",
"xpack.ml.jobsList.deleteJobModal.closeButtonLabel": "关闭",
"xpack.ml.jobsList.deleteJobModal.deleteButtonLabel": "删除",
"xpack.ml.jobsList.deleteJobModal.deleteJobsDescription": "是否确定要删除{jobsCount, plural, one {此作业} other {这些作业}}？",
"xpack.ml.jobsList.deleteJobModal.deleteJobsTitle": "删除 {jobsCount, plural, one {{jobId}} other {# 个作业}}",
"xpack.ml.jobsList.deleteJobModal.deleteMultipleJobsDescription": "删除{jobsCount, plural, one {一个作业} other {多个作业}}会非常耗时。将在后台删除{jobsCount, plural, one {该作业} other {这些作业}}，但删除的作业可能不会立即从作业列表中消失",
"xpack.ml.jobsList.deleteJobModal.deletingJobsStatusLabel": "正在删除作业",
Expand Down Expand Up @@ -12307,7 +12306,6 @@
"xpack.ml.ruleEditor.deleteJobRule.ruleNoLongerExistsErrorMessage": "作业 {jobId} 中不再存在检测工具索引 {detectorIndex} 的规则",
"xpack.ml.ruleEditor.deleteRuleModal.cancelButtonLabel": "取消",
"xpack.ml.ruleEditor.deleteRuleModal.deleteButtonLabel": "删除",
"xpack.ml.ruleEditor.deleteRuleModal.deleteRuleDescription": "是否确定要删除此规则？",
"xpack.ml.ruleEditor.deleteRuleModal.deleteRuleLinkText": "删除规则",
"xpack.ml.ruleEditor.deleteRuleModal.deleteRuleTitle": "删除规则",
"xpack.ml.ruleEditor.detectorDescriptionList.detectorTitle": "检测工具",
Expand Down