[canvas] migrate tests away from karma #73121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
commented
Jul 23, 2020
| ]); | ||
| expect(newState.resolvedArgs['element-1']).toMatchInlineSnapshot(` | ||
| Object { | ||
| "0": Object { |
There was a problem hiding this comment.
This is the return value produced by resolvedArgsReducer() which used to work by the check that .to.eql() ran. Jest assertions are a bit more picky (in a good way, the return value shouldn't eql an array) but I just wanted to raise awareness a little... this is weirdness
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
|
Thanks for doing this. Checked the storyshots and tests... all looks good! FYI: the removed storyshot is due to a PR I merged that prevents Redux-based Storybook stories from being 'shotted. |
clintandrewhall
approved these changes
Jul 25, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 27, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get closer to being able to stop using Karma we need to move canvas tests that are using Karma to use Jest instead.
Most tests moved over pretty easy, a couple places made sense to switch to TS quickly.