[Security Solution] Adding aggregations for endpoint events #72705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bool: { | ||
| should: [ | ||
| { | ||
| term: { |
There was a problem hiding this comment.
We're treating library and driver events as image load.
| bool: { | ||
| filter: [ | ||
| { | ||
| bool: { |
There was a problem hiding this comment.
Network is anything but dns
| should: [ | ||
| { | ||
| bool: { | ||
| filter: [ |
There was a problem hiding this comment.
Security events for endpoint should be an array of two values for event.category == [session, authentication]
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
michaelolo24
approved these changes
Jul 21, 2020
|
Can you make an issue for cleaning up the names that we can come back to later on? |
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
This was referenced Jul 22, 2020
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Jul 22, 2020
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Jul 22, 2020
jonathan-buttner
added a commit
that referenced
this pull request
Jul 22, 2020
jonathan-buttner
added a commit
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for aggregating totals for endpoint data and endgame data. We should probably do some cleanup on the variable names to switch them over to
endpointor some combination ofendpointandendgame. This is a bug fix so I have not done the refactoring in this PR.Endpoint only data
Endgame Data
Both Endpoint and Endgame Data
