[APM] Update ML job ID in data telemetry tasks #71044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "apm-*" to match the new job IDs added in elastic#70560.
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
reviewed
Jul 8, 2020
| const response = (await transportRequest({ | ||
| method: 'get', | ||
| path: `/_ml/anomaly_detectors/${apmJobs.join(',')}`, | ||
| path: `/_ml/anomaly_detectors/${ML_GROUP_NAME_APM}-*`, |
There was a problem hiding this comment.
I don't think you need the wildcard since this is returning all jobs with the given group
Suggested change
| path: `/_ml/anomaly_detectors/${ML_GROUP_NAME_APM}-*`, | |
| path: `/_ml/anomaly_detectors/${ML_GROUP_NAME_APM}`, |
There was a problem hiding this comment.
Is that right? Before we were *-high_mean_response_time. Also, we should probably keep that previous value as well since we'll want to count both the old and new jobs.
sorenlouv
reviewed
Jul 8, 2020
| @@ -465,17 +466,17 @@ export const tasks: TelemetryTask[] = [ | |||
| { | |||
| name: 'integrations', | |||
| executor: async ({ transportRequest }) => { | |||
| const apmJobs = ['*-high_mean_response_time']; | |||
| const apmJobs = ['apm-*', '*-high_mean_response_time']; | |||
|
|
|||
| const response = (await transportRequest({ | |||
| method: 'get', | |||
| path: `/_ml/anomaly_detectors/${apmJobs.join(',')}`, | |||
There was a problem hiding this comment.
Using GET /_ml/anomaly_detectors/${ML_GROUP_NAME_APM} will return all jobs with group=${ML_GROUP_NAME_APM} so should also work for old jobs.
sorenlouv
approved these changes
Jul 8, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Jul 9, 2020
* [APM] Update ML job ID in data telemetry tasks Use "apm-*" to match the new job IDs added in elastic#70560. * additional fix * Remove unused import
smith
added a commit
that referenced
this pull request
Jul 9, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 9, 2020
* master: (39 commits) [APM] Add warning to notify user about legacy ML jobs (elastic#71030) updates consumer to siem (elastic#71117) Index pattern creation flow - fix spelling (elastic#71192) [Security Solution][Endpoint] User Manifest Cleanup + Artifact Compression (elastic#70759) [SECURITY] Rearrange rule name's column in Alert Table (elastic#71020) [SECURITY] Alerts back to Detections (elastic#71142) [Security Solution][Exceptions Builder] - Fixes operator selection bug (elastic#71178) [SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files. [APM] Update ML job ID in data telemetry tasks (elastic#71044) [Resolver] Remove `currentPanelView` selector (elastic#71154) add meta.managed to index templates (elastic#71135) Clarify trial subscription levels (elastic#70900) [Security Solution] fix panel links (elastic#71148) skip flaky suite (elastic#69632) skip suite failing ES Promotion (elastic#71018) [ML] DF Analytics: add results field to wizard and show regression stats (elastic#70893) [SIEM] update wordings (elastic#71119) [SECURITY SOLUTION] Rename to hosts and administration (elastic#70913) [ML] Improvements for urlState hook. (elastic#70576) Removing uptime guide (elastic#71124) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "apm-*" to match the new job IDs added in #70560.