Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Make alert instance IDs more useful #70100

Merged
merged 3 commits into from
Jun 30, 2020
Merged

[Metrics UI] Make alert instance IDs more useful #70100

merged 3 commits into from
Jun 30, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jun 26, 2020

Summary

Switches around how alert IDs are created in the threshold and inventory executors so that they're more readable in the alert management screen.

Before

Screen Shot 2020-06-26 at 12 01 43 PM

After

Screen Shot 2020-06-26 at 11 58 01 AM

Note that the delimiter between the group and alertId is now :: because group names seem to use - a lot.

@Zacqary Zacqary added release_note:enhancement Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 26, 2020
@Zacqary Zacqary requested a review from a team as a code owner June 26, 2020 17:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary
Copy link
Contributor Author

Zacqary commented Jun 29, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

phillipb
phillipb approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit 0f78bc9 into elastic:master Jun 30, 2020
@Zacqary Zacqary deleted the alertid-improve branch June 30, 2020 17:59
@Zacqary Zacqary mentioned this pull request Jun 30, 2020
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jun 30, 2020
@Zacqary @elasticmachine
[Metrics UI] Make alert instance IDs more useful (elastic#70100)
3943232 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Zacqary added a commit that referenced this pull request Jun 30, 2020
@Zacqary @elasticmachine
[7.x] [Metrics UI] Make alert instance IDs more useful (#70100) (#70346)
2b1bfcc 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
@Zacqary @elasticmachine @Bamieh
[Metrics UI] Make alert instance IDs more useful (elastic#70100)
0666e5e 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Zacqary Zacqary added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zacqary @elasticmachine @kibanamachine @phillipb