Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.8] [Maps] Remove extra layer of telemetry nesting under "attributes" (#66137) #69754

Merged
merged 5 commits into from
Jun 24, 2020
Merged

[7.8] [Maps] Remove extra layer of telemetry nesting under "attributes" (#66137) #69754

merged 5 commits into from
Jun 24, 2020

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Jun 23, 2020

Backports the following commits to 7.8:

[Maps] Remove extra layer of telemetry nesting under "attributes" (el…
0c82155 
…astic#66137)

* Return attributes when telemetry created instead of whole saved object. Update integration test

* Change 'maps-telemetry' to 'maps'

* No need to create a saved object anymore. This is leftover from task manager telemetry mgmt

* Add test confirming attrs undefined. Change tests to check for 'maps' iso 'maps-telemetry'

* Add two more tests confirming expected telemetry shape

* Review feedback. Use TELEMETRY_TYPE constant and set to APP_ID
# Conflicts:
#	x-pack/plugins/maps/server/maps_telemetry/maps_telemetry.ts
@kindsun kindsun force-pushed the backport/7.8/pr-66137 branch from d650ac0 to d60c3c7 Compare June 23, 2020 21:51
@kindsun kindsun mentioned this pull request Jun 24, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load asset size

beta
id value diff baseline
/bundles/commons.style.css - -36.9KB 36.9KB
/bundles/core/core.entry.js - -1014.1KB 1014.1KB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.@elastic.js - -3.7MB 3.7MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.css - -183.7KB 183.7KB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js - -4.4MB 4.4MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.light.css - -490.9KB 490.9KB
/bundles/light_theme.style.css - -95.9KB 95.9KB
/bundles/plugin/advancedSettings/advancedSettings.plugin.js - -942.5KB 942.5KB
/bundles/plugin/advancedUiActions/advancedUiActions.plugin.js - -626.7KB 626.7KB
/bundles/plugin/alerting/alerting.plugin.js - -88.5KB 88.5KB
/bundles/plugin/apm/apm.plugin.js - -877.2KB 877.2KB
/bundles/plugin/apm_oss/apm_oss.plugin.js - -3.9KB 3.9KB
/bundles/plugin/bfetch/bfetch.plugin.js - -29.1KB 29.1KB
/bundles/plugin/canvas/canvas.plugin.js - -3.3MB 3.3MB
/bundles/plugin/charts/charts.plugin.js - -893.7KB 893.7KB
/bundles/plugin/cloud/cloud.plugin.js - -5.4KB 5.4KB
/bundles/plugin/console/console.plugin.js - -46.7KB 46.7KB
/bundles/plugin/crossClusterReplication/crossClusterReplication.plugin.js - -153.6KB 153.6KB
/bundles/plugin/dashboard/dashboard.plugin.js - -1.1MB 1.1MB
/bundles/plugin/dashboardEnhanced/dashboardEnhanced.plugin.js - -1.3MB 1.3MB
/bundles/plugin/data/data.plugin.js - -1.6MB 1.6MB
/bundles/plugin/dataEnhanced/dataEnhanced.plugin.js - -487.2KB 487.2KB
/bundles/plugin/devTools/devTools.plugin.js - -120.0KB 120.0KB
/bundles/plugin/discover/discover.plugin.js - -318.6KB 318.6KB
/bundles/plugin/drilldowns/drilldowns.plugin.js - -671.7KB 671.7KB
/bundles/plugin/embeddable/embeddable.plugin.js - -525.0KB 525.0KB
/bundles/plugin/embeddableEnhanced/embeddableEnhanced.plugin.js - -650.4KB 650.4KB
/bundles/plugin/esUiShared/esUiShared.plugin.js - -789.1KB 789.1KB
/bundles/plugin/expressions/expressions.plugin.js - -712.3KB 712.3KB
/bundles/plugin/features/features.plugin.js - -13.3KB 13.3KB
/bundles/plugin/fileUpload/fileUpload.plugin.js - -687.8KB 687.8KB
/bundles/plugin/graph/graph.plugin.js - -207.2KB 207.2KB
/bundles/plugin/grokdebugger/grokdebugger.plugin.js - -30.8KB 30.8KB
/bundles/plugin/home/home.plugin.js - -24.3KB 24.3KB
/bundles/plugin/indexLifecycleManagement/indexLifecycleManagement.plugin.js - -182.3KB 182.3KB
/bundles/plugin/indexManagement/indexManagement.plugin.js - -851.2KB 851.2KB
/bundles/plugin/indexPatternManagement/indexPatternManagement.plugin.js - -20.7KB 20.7KB
/bundles/plugin/infra/infra.plugin.js - -1.1MB 1.1MB
/bundles/plugin/ingestPipelines/ingestPipelines.plugin.js - -267.9KB 267.9KB
/bundles/plugin/inputControlVis/inputControlVis.plugin.js - -256.7KB 256.7KB
/bundles/plugin/inspector/inspector.plugin.js - -238.6KB 238.6KB
/bundles/plugin/kibanaLegacy/kibanaLegacy.plugin.js - -176.3KB 176.3KB
/bundles/plugin/kibanaReact/kibanaReact.plugin.js - -567.2KB 567.2KB
/bundles/plugin/kibanaUtils/kibanaUtils.plugin.js - -478.6KB 478.6KB
/bundles/plugin/lens/lens.plugin.js - -1.8MB 1.8MB
/bundles/plugin/licenseManagement/licenseManagement.plugin.js - -25.1KB 25.1KB
/bundles/plugin/licensing/licensing.plugin.js - -20.1KB 20.1KB
/bundles/plugin/logstash/logstash.plugin.js - -164.7KB 164.7KB
/bundles/plugin/management/management.plugin.js - -173.7KB 173.7KB
/bundles/plugin/maps/maps.plugin.js - -228.3KB 228.3KB
/bundles/plugin/mapsLegacy/mapsLegacy.plugin.js - -1.5MB 1.5MB
/bundles/plugin/mapsLegacyLicensing/mapsLegacyLicensing.plugin.js - -3.6KB 3.6KB
/bundles/plugin/ml/ml.plugin.js - -1.4MB 1.4MB
/bundles/plugin/monitoring/monitoring.plugin.js - -40.1KB 40.1KB
/bundles/plugin/navigation/navigation.plugin.js - -123.4KB 123.4KB
/bundles/plugin/newsfeed/newsfeed.plugin.js - -30.7KB 30.7KB
/bundles/plugin/observability/observability.plugin.js - -95.7KB 95.7KB
/bundles/plugin/painlessLab/painlessLab.plugin.js - -178.5KB 178.5KB
/bundles/plugin/remoteClusters/remoteClusters.plugin.js - -38.1KB 38.1KB
/bundles/plugin/reporting/reporting.plugin.js - -707.2KB 707.2KB
/bundles/plugin/rollup/rollup.plugin.js - -266.9KB 266.9KB
/bundles/plugin/savedObjects/savedObjects.plugin.js - -194.7KB 194.7KB
/bundles/plugin/savedObjectsManagement/savedObjectsManagement.plugin.js - -43.7KB 43.7KB
/bundles/plugin/searchprofiler/searchprofiler.plugin.js - -61.5KB 61.5KB
/bundles/plugin/security/security.plugin.js - -268.2KB 268.2KB
/bundles/plugin/share/share.plugin.js - -74.3KB 74.3KB
/bundles/plugin/siem/siem.plugin.js - -277.5KB 277.5KB
/bundles/plugin/snapshotRestore/snapshotRestore.plugin.js - -59.7KB 59.7KB
/bundles/plugin/spaces/spaces.plugin.js - -455.0KB 455.0KB
/bundles/plugin/statusPage/statusPage.plugin.js - -3.3KB 3.3KB
/bundles/plugin/telemetry/telemetry.plugin.js - -77.1KB 77.1KB
/bundles/plugin/telemetryManagementSection/telemetryManagementSection.plugin.js - -8.8KB 8.8KB
/bundles/plugin/transform/transform.plugin.js - -39.2KB 39.2KB
/bundles/plugin/triggers_actions_ui/triggers_actions_ui.plugin.js - -672.5KB 672.5KB
/bundles/plugin/uiActions/uiActions.plugin.js - -158.6KB 158.6KB
/bundles/plugin/upgradeAssistant/upgradeAssistant.plugin.js - -45.9KB 45.9KB
/bundles/plugin/uptime/uptime.plugin.js - -2.4MB 2.4MB
/bundles/plugin/usageCollection/usageCollection.plugin.js - -28.0KB 28.0KB
/bundles/plugin/visTypeMarkdown/visTypeMarkdown.plugin.js - -563.3KB 563.3KB
/bundles/plugin/visTypeMetric/visTypeMetric.plugin.js - -961.6KB 961.6KB
/bundles/plugin/visTypeTable/visTypeTable.plugin.js - -1.0MB 1.0MB
/bundles/plugin/visTypeTagcloud/visTypeTagcloud.plugin.js - -962.4KB 962.4KB
/bundles/plugin/visTypeTimelion/visTypeTimelion.plugin.js - -726.8KB 726.8KB
/bundles/plugin/visTypeTimeseries/visTypeTimeseries.plugin.js - -217.5KB 217.5KB
/bundles/plugin/visTypeVega/visTypeVega.plugin.js - -1.6MB 1.6MB
/bundles/plugin/visTypeVislib/visTypeVislib.plugin.js - -1.5MB 1.5MB
/bundles/plugin/visualizations/visualizations.plugin.js - -871.9KB 871.9KB
/bundles/plugin/visualize/visualize.plugin.js - -35.0KB 35.0KB
/bundles/plugin/watcher/watcher.plugin.js - -52.8KB 52.8KB
/node_modules/@kbn/ui-framework/dist/kui_light.css - -62.1KB 62.1KB
/translations/en.json - -29.0B 29.0B
/ui/fonts/inter_ui/Inter-UI-Medium.woff2 - -92.2KB 92.2KB
/ui/fonts/inter_ui/Inter-UI-Regular.woff2 - -86.4KB 86.4KB
/ui/fonts/inter_ui/Inter-UI-SemiBold.woff2 - -92.5KB 92.5KB
total - -50.1MB -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit ec0eb47 into elastic:7.8 Jun 24, 2020
@kindsun kindsun deleted the backport/7.8/pr-66137 branch June 24, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kindsun @kibanamachine