Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Design updates for alert preview results #69328

Merged
merged 19 commits into from
Jun 30, 2020
Merged

[Metrics UI] Design updates for alert preview results #69328

merged 19 commits into from
Jun 30, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jun 16, 2020

Summary

Closes #69293

Screen Shot 2020-06-16 at 2 43 22 PM

Screen Shot 2020-06-16 at 2 43 45 PM

Screen Shot 2020-06-16 at 2 44 11 PM

Screen Shot 2020-06-16 at 2 44 19 PM

Screen Shot 2020-06-16 at 2 45 52 PM

Screen Shot 2020-06-16 at 2 45 55 PM

Checklist

Delete any items that are not applicable to this PR.

@Zacqary Zacqary added Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 16, 2020
Zacqary added 4 commits June 17, 2020 12:22
@Zacqary
Fix typecheck
6839262
@Zacqary
Fix typecheck again
5096f38
@Zacqary
Merge remote-tracking branch 'upstream/master' into 69293-alert-previ…
e80559e 
…ew-updates

# Conflicts:
#	x-pack/plugins/infra/public/alerting/common/index.ts
#	x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx
#	x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
#	x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/preview_inventory_metric_threshold_alert.ts
@Zacqary
Fix merge
6903098
@Zacqary Zacqary marked this pull request as ready for review June 24, 2020 20:01
@Zacqary Zacqary requested a review from a team as a code owner June 24, 2020 20:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary added the release_note:skip Skip the PR/issue when compiling release notes label Jun 24, 2020
Zacqary added 2 commits June 24, 2020 16:29
@Zacqary
Fix typecheck
e07ac0b
@Zacqary
Merge remote-tracking branch 'upstream/master' into 69293-alert-previ…
276d6d5 
…ew-updates

# Conflicts:
#	x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
@Zacqary
Copy link
Contributor Author

Zacqary commented Jun 25, 2020

@elasticmachine merge upstream

@Zacqary
Copy link
Contributor Author

Zacqary commented Jun 29, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb self-requested a review June 30, 2020 17:27
phillipb
phillipb approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit c948e47 into elastic:master Jun 30, 2020
@Zacqary Zacqary deleted the 69293-alert-preview-updates branch June 30, 2020 18:00
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jun 30, 2020
@Zacqary @elasticmachine
[Metrics UI] Design updates for alert preview results (elastic#69328)
e95fac6 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Zacqary Zacqary mentioned this pull request Jun 30, 2020
Merged
@hbharding
Copy link
Contributor

Thanks @Zacqary lgtm!

Zacqary added a commit that referenced this pull request Jun 30, 2020
@Zacqary @elasticmachine
[7.x] [Metrics UI] Design updates for alert preview results (#69328) (#…
a78bdcc 
…70347)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
@Zacqary @elasticmachine @Bamieh
[Metrics UI] Design updates for alert preview results (elastic#69328)
49cc8cf 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Alert preview design updates
5 participants
@Zacqary @elasticmachine @kibanamachine @hbharding @phillipb