Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Add a get-panel-actions csv test #68825

Merged
merged 3 commits into from
Jun 11, 2020
Merged

[Reporting] Add a get-panel-actions csv test #68825

merged 3 commits into from
Jun 11, 2020

Conversation

joelgriffith
Copy link
Contributor

Adds a test for the get-panel-action CSV Panel Action!

Removes a module from our untested-module list (#68724). This one, in particular, is of greater importance, and I was able to catch a few bugs doing so!

@joelgriffith joelgriffith requested a review from tsullivan June 10, 2020 21:48
@joelgriffith joelgriffith added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jun 10, 2020
@joelgriffith
Copy link
Contributor Author

@elastic/kibana-qa this PR shouldn't need any test plans as it simply introduces a newer test suite into our codebase.

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joelgriffith joelgriffith merged commit ae8f6e3 into elastic:master Jun 11, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 15, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 68825 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 68825 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 68825 or prevent reminders by adding the backport:skip label.

joelgriffith pushed a commit that referenced this pull request Jun 18, 2020
* Adds in a get-panel-actions csv test
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants