Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service maps - adds new storybook stories to test out various data sets #68727

Merged
merged 3 commits into from
Jun 11, 2020
Merged

[APM] Service maps - adds new storybook stories to test out various data sets #68727

merged 3 commits into from
Jun 11, 2020

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Jun 10, 2020 •
edited
Loading

Addresses #62814

  • move cytoscape stories-related files to stories
  • adds story to generate/render service map response data
  • adds story that renders any service map response json
  • adds story that renders opbeans test data

Screen Shot 2020-06-09 at 5 00 34 PM

@ogupte
- move cytoscape stories-related files to __stories__
d6cc383 
- adds story to generate/render service map response data
- adds story that renders any service map response json
- adds story that renders opbeans test data
@ogupte ogupte added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 10, 2020
@ogupte ogupte requested a review from a team as a code owner June 10, 2020 00:02
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

smith
smith approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool!

x-pack/plugins/apm/public/components/app/ServiceMap/__stories__/Cytoscape.stories.tsx
@@ -0,0 +1,327 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually don't think it's necessary to put this in a __stories__ directory, but since we have a lot of examples I can see why we would do it.

x-pack/plugins/apm/public/components/app/ServiceMap/__stories__/Cytoscape.stories.tsx
import { iconForNode } from '../icons';

storiesOf('app/ServiceMap/Cytoscape', module).add(
'example',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably can remove this example since we have other more complete ones now.

...ck/plugins/apm/public/components/app/ServiceMap/__stories__/CytoscapeExampleData.stories.tsx Outdated
);

storiesOf(STORYBOOK_PATH, module).add(
'pre-loaded map',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better name might be "map from JSON"

...ck/plugins/apm/public/components/app/ServiceMap/__stories__/CytoscapeExampleData.stories.tsx
);
},
{
info: { propTables: false, source: false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could put a text key under info to provide instructions on how to get data in here.

@ogupte
Copy link
Contributor Author

ogupte commented Jun 11, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit 9c4b466 into elastic:master Jun 11, 2020
ogupte added a commit to ogupte/kibana that referenced this pull request Jun 11, 2020
@ogupte @elasticmachine
[APM] Service maps - adds new storybook stories to test out various d…
be53a52 
…ata sets (elastic#68727)

* - move cytoscape stories-related files to __stories__
- adds story to generate/render service map response data
- adds story that renders any service map response json
- adds story that renders opbeans test data

* added example data for 'Hipster store' and 'Todo app'

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@ogupte ogupte mentioned this pull request Jun 11, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 11, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
34b7cf9 
* master: (38 commits)
  Support migrating from reserved feature privileges (elastic#68504)
  add `preference` field to SavedObjectsFindOptions (elastic#68620)
  [ILM] Add "wait for snapshot" policy field to Delete phase (elastic#68505)
  Cleanup old license overwrites (elastic#68744)
  Bump TypeScript to v3.9 (elastic#67666)
  [APM] Service maps - adds new storybook stories to test out various data sets (elastic#68727)
  Fix vega specification parsing (elastic#67963)
  docs: add more api information (elastic#68717)
  [APM] Don't show annotations on charts with no data (elastic#68829)
  [Metrics UI] Fix Inventory View sorting by handling null values (elastic#67889)
  skip flaky suite (elastic#68836)
  [SIEM][Detections Engine] - Fix reference rule url overflow (elastic#68640)
  Index pattern public api => common (elastic#68289)
  [APM] Lazy-load alert triggers (elastic#68806)
  [DOCS] Fix table formatting in ingest manager settings (elastic#68824)
  [Endpoint] Functional Tests cleanup (elastic#68756)
  revert previous commit which was unintentional
  Use Github token instead for project assignments
  [SIEM][Exceptions] - ExceptionsViewer cleanup (elastic#68739)
  move @kbn/storybook to devDeps (elastic#68791)
  ...
ogupte added a commit that referenced this pull request Jun 11, 2020
@ogupte @elasticmachine
[APM] Service maps - adds new storybook stories to test out various d…
3e0ae86 
…ata sets (#68727) (#68869)

* - move cytoscape stories-related files to __stories__
- adds story to generate/render service map response data
- adds story that renders any service map response json
- adds story that renders opbeans test data

* added example data for 'Hipster store' and 'Todo app'

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogupte @elasticmachine @kibanamachine @smith