Populate RequestHandlerContext with start API only #67579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-platform (Team:Platform) |
… into issue-55397-es-from-start
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
joshdover
approved these changes
May 28, 2020
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
May 28, 2020
* use start API to populate request context * remove client creation from uiSettings service setup API * remove __internals.uiSettings * update ui_settings mixin tests
mshustov
added a commit
that referenced
this pull request
May 28, 2020
* use start API to populate request context * remove client creation from uiSettings service setup API * remove __internals.uiSettings * update ui_settings mixin tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent issue: #55397
This PR switches the request context handler creation to use start API.
I also removed
asScopedToClient(internal platform API) from uiSettings setup contract.Checklist
For maintainers