-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry uses es client provided from start contract #67279
Conversation
telemetryCollectionManager.setCollection({ | ||
esCluster: core.elasticsearch.dataClient, | ||
esCluster: core.elasticsearch.legacy.client, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afharo do you know a reason why it wouldn't work if we move setCollection
to the start lifecycle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet there's a point in the code where we are trying to read the telemetry from the setup
lifecycle step (on top of my mind
bulkUploader.start(plugins.usageCollection); |
I can try to dig deeper on it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where we are trying to read the telemetry from the
Ha. Good to know, thanks! I will try to move this piece of the code in start
lifecycle. That definitely shouldn't be in setup
, since telemetry API might be called by other plugins during setup
.
I can try to dig deeper on it :)
I will ping you if I didn't fix it with ^^^
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/telemetry/telemetry_local·js.apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data typesStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/telemetry/telemetry_local·js.apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data typesStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Summary
Part of #55397
Required to get rid elasticsearch API provided from
setup
lifecycle.