-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xpack/jest_integration] remove flaky test and script block #67138
Merged
spalger
merged 1 commit into
elastic:master
from
spalger:remove/flaky-jest-integration-block
May 21, 2020
Merged
[xpack/jest_integration] remove flaky test and script block #67138
spalger
merged 1 commit into
elastic:master
from
spalger:remove/flaky-jest-integration-block
May 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/discover·ts.Discover should open context view on a docStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
spalger
added
v7.7.1
v7.8.0
v7.9.0
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
labels
May 20, 2020
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
May 21, 2020
mistic
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Dec 22, 2020
This file was deleted in elastic#67138.
rylnd
added a commit
that referenced
this pull request
Jan 5, 2021
* Update/refactor some cypress documentation * Fixes some whitespace/grammar/typos * Condenses the explanation/instructions for the different modes of execution * Condense Artifacts section This is a big sprawling file; trying to cut down on the noise. * Move test-running section to top of README This is going to be what 90% of readers are looking for, methinks. * Adds Security Solution's cypress suite to x-pack testing README * Fix broken link This file was moved as part of #64368. * Remove broken link This file was deleted in #67138. * Apply suggestions from code review Co-authored-by: Devin W. Hurley <snowmiser111@gmail.com> * Fix typo Co-authored-by: Devin W. Hurley <snowmiser111@gmail.com>
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Jan 5, 2021
* Update/refactor some cypress documentation * Fixes some whitespace/grammar/typos * Condenses the explanation/instructions for the different modes of execution * Condense Artifacts section This is a big sprawling file; trying to cut down on the noise. * Move test-running section to top of README This is going to be what 90% of readers are looking for, methinks. * Adds Security Solution's cypress suite to x-pack testing README * Fix broken link This file was moved as part of elastic#64368. * Remove broken link This file was deleted in elastic#67138. * Apply suggestions from code review Co-authored-by: Devin W. Hurley <snowmiser111@gmail.com> * Fix typo Co-authored-by: Devin W. Hurley <snowmiser111@gmail.com>
rylnd
added a commit
that referenced
this pull request
Jan 5, 2021
* Update/refactor some cypress documentation * Fixes some whitespace/grammar/typos * Condenses the explanation/instructions for the different modes of execution * Condense Artifacts section This is a big sprawling file; trying to cut down on the noise. * Move test-running section to top of README This is going to be what 90% of readers are looking for, methinks. * Adds Security Solution's cypress suite to x-pack testing README * Fix broken link This file was moved as part of #64368. * Remove broken link This file was deleted in #67138. * Apply suggestions from code review Co-authored-by: Devin W. Hurley <snowmiser111@gmail.com> * Fix typo Co-authored-by: Devin W. Hurley <snowmiser111@gmail.com> Co-authored-by: Devin W. Hurley <snowmiser111@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.7.1
v7.8.0
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67108
In order to unblock the security team we should remove the old flaky test we tried to skip by disabling the jest_integration script in x-pack. The tests still won't execute on CI unless the following lines are uncommented in the first PR:
kibana/test/scripts/jenkins_xpack.sh
Lines 24 to 28 in 2be7a9b