-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bootstrap/styles] add early support for v8 themes #66673
Conversation
...ore_plugins/kibana/public/management/sections/index_patterns/create_button/create_button.tsx
Outdated
Show resolved
Hide resolved
I did a quick run through this last night, and it worked as I'd expect. I don't think all the JSON import conversions needs to be done in this PR, but the method/example you set up makes sense to me and is clean. Thanks for jumping on this so quickly, it's really gonna help us as we build out the new theme. |
@elasticmachine merge upstream |
@spalger Is this reviewable? |
Pinging @elastic/kibana-operations (Team:Operations) |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Ops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this in browser to make sure it works how I'd suspect. I also did a brief run through of the code to make sure it's flexible enough for designs needs. Likely there will be some downstream changes in the apps that will need to follow, but nothing with the current defaults will have any ripples from this change.
Thanks for adding this one so quickly. 🎉
Fixes #61123
Summary
Implements initial support for the version 8 themes the EUI team is working on. To switch between themes there is a
theme:version
advanced setting which currently has two possible valuesv7
andv8
. Changing this value and reloading the page will load the v7 or v8 css styles from@kbn/ui-shared-deps
and thev7
orv8
theme files will be exported from@elastic/eui/dist/eui_theme_light.json
,@elastic/eui/dist/eui_theme_dark.json
,as well as a new module@kbn/ui-shared-deps/eui_theme
. This new module exportseuiThemeDark
andeuiThemeLight
which represent the two previously mentioned sets of theme vars, as well aseuiTheme
which is automatically mapped to the right theme based on the current value of thetheme:*
settings.Checklist
Delete any items that are not applicable to this PR.
For maintainers