Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bootstrap/styles] add early support for v8 themes #66673

Merged
merged 11 commits into from
May 21, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 14, 2020

Fixes #61123

Summary

Implements initial support for the version 8 themes the EUI team is working on. To switch between themes there is a theme:version advanced setting which currently has two possible values v7 and v8. Changing this value and reloading the page will load the v7 or v8 css styles from @kbn/ui-shared-deps and the v7 or v8 theme files will be exported from @elastic/eui/dist/eui_theme_light.json, @elastic/eui/dist/eui_theme_dark.json, as well as a new module @kbn/ui-shared-deps/eui_theme. This new module exports euiThemeDark and euiThemeLight which represent the two previously mentioned sets of theme vars, as well as euiTheme which is automatically mapped to the right theme based on the current value of the theme:* settings.

2020-05-14 16 10 05

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ryankeairns ryankeairns requested review from cchaos and snide May 15, 2020 14:20
@snide
Copy link
Contributor

snide commented May 15, 2020

I did a quick run through this last night, and it worked as I'd expect. I don't think all the JSON import conversions needs to be done in this PR, but the method/example you set up makes sense to me and is clean.

Thanks for jumping on this so quickly, it's really gonna help us as we build out the new theme.

@spalger
Copy link
Contributor Author

spalger commented May 15, 2020

@elasticmachine merge upstream

@snide
Copy link
Contributor

snide commented May 19, 2020

@spalger Is this reviewable?

@spalger spalger added Team:Operations Team label for Operations Team v7.9.0 v8.0.0 labels May 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger added release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels May 19, 2020
@spalger spalger marked this pull request as ready for review May 19, 2020 14:15
@spalger spalger requested a review from a team as a code owner May 19, 2020 14:15
@spalger
Copy link
Contributor Author

spalger commented May 20, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger requested a review from a team May 20, 2020 21:09
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Ops

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this in browser to make sure it works how I'd suspect. I also did a brief run through of the code to make sure it's flexible enough for designs needs. Likely there will be some downstream changes in the apps that will need to follow, but nothing with the current defaults will have any ripples from this change.

Thanks for adding this one so quickly. 🎉

@spalger spalger merged commit 93c3a63 into elastic:master May 21, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request May 21, 2020
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request May 21, 2020
spalger pushed a commit that referenced this pull request May 22, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger deleted the switch-between-v8-themes branch August 18, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced settings toggle for new EUI theme
7 participants