Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es6ify] re-apply automated transforms after ingest work #6623

Merged
merged 6 commits into from
Mar 24, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const modules = require('ui/modules');
const template = require('plugins/kibana/settings/sections/indices/add_data_steps/pattern_review_step.html');
const _ = require('lodash');
const editFieldTypeHTML = require('plugins/kibana/settings/sections/indices/partials/_edit_field_type.html');
import modules from 'ui/modules';
import template from 'plugins/kibana/settings/sections/indices/add_data_steps/pattern_review_step.html';
import _ from 'lodash';
import editFieldTypeHTML from 'plugins/kibana/settings/sections/indices/partials/_edit_field_type.html';

function pickDefaultTimeFieldName(dateFields) {
if (_.isEmpty(dateFields)) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import uiModules from 'ui/modules';
import jsondiffpatch from '@bigfunger/jsondiffpatch';
import '../styles/_output_preview.less';
import outputPreviewTemplate from '../views/output_preview.html';

const htmlFormat = jsondiffpatch.formatters.html.format;
const app = uiModules.get('kibana');

app.directive('outputPreview', function () {
return {
restrict: 'E',
template: require('../views/output_preview.html'),
template: outputPreviewTemplate,
scope: {
oldObject: '=',
newObject: '='
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import uiModules from 'ui/modules';
import '../styles/_pipeline_output.less';
import pipelineOutputTemplate from '../views/pipeline_output.html';

const app = uiModules.get('kibana');

app.directive('pipelineOutput', function () {
return {
restrict: 'E',
template: require('../views/pipeline_output.html'),
template: pipelineOutputTemplate,
scope: {
pipeline: '='
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import '../styles/_pipeline_setup.less';
import './pipeline_output';
import './source_data';
import './processor_ui';
import pipelineSetupTemplate from '../views/pipeline_setup.html';

const app = uiModules.get('kibana');
function buildProcessorTypeList() {
Expand All @@ -27,7 +28,7 @@ function buildProcessorTypeList() {
app.directive('pipelineSetup', function () {
return {
restrict: 'E',
template: require('../views/pipeline_setup.html'),
template: pipelineSetupTemplate,
scope: {
samples: '=',
pipeline: '='
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import _ from 'lodash';
import '../styles/_processor_ui_container.less';
import './output_preview';
import './processor_ui_container_header';
import processorUiContainerTemplate from '../views/processor_ui_container.html';

const app = uiModules.get('kibana');

Expand All @@ -13,7 +14,7 @@ app.directive('processorUiContainer', function ($compile) {
pipeline: '=',
processor: '='
},
template: require('../views/processor_ui_container.html'),
template: processorUiContainerTemplate,
link: function ($scope, $el) {
const processor = $scope.processor;
const pipeline = $scope.pipeline;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import uiModules from 'ui/modules';
import '../styles/_processor_ui_container_header.less';
import processorUiContainerHeaderTemplate from '../views/processor_ui_container_header.html';

const app = uiModules.get('kibana');

Expand All @@ -11,6 +12,6 @@ app.directive('processorUiContainerHeader', function () {
field: '=',
pipeline: '='
},
template: require('../views/processor_ui_container_header.html')
template: processorUiContainerHeaderTemplate
};
});
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import uiModules from 'ui/modules';
import processorUiSetTemplate from '../views/processor_ui_set.html';

const app = uiModules.get('kibana');

//scope.processor, scope.pipeline are attached by the process_container.
app.directive('processorUiSet', function () {
return {
restrict: 'E',
template: require('../views/processor_ui_set.html'),
template: processorUiSetTemplate,
controller : function ($scope) {
const processor = $scope.processor;
const pipeline = $scope.pipeline;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import uiModules from 'ui/modules';
import angular from 'angular';
import '../styles/_source_data.less';
import sourceDataTemplate from '../views/source_data.html';

const app = uiModules.get('kibana');

Expand All @@ -11,7 +12,7 @@ app.directive('sourceData', function () {
samples: '=',
sample: '='
},
template: require('../views/source_data.html'),
template: sourceDataTemplate,
controller: function ($scope) {
const samples = $scope.samples;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
import PluginsKibanaSettingsSectionsIndicesRefreshKibanaIndexProvider from 'plugins/kibana/settings/sections/indices/_refresh_kibana_index';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the script got a bit carried away with the naming here ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, yeah.... use relative paths!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been:

import refreshKibanaIndexProvider from '../_refresh_kibana_index'

import uiModules from 'ui/modules';
import kbnSettingsIndicesTemplate from 'plugins/kibana/settings/sections/indices/directives/kbn_settings_indices.html';

// wrapper directive, which sets some global stuff up like the left nav
require('ui/modules').get('apps/settings')
uiModules.get('apps/settings')
.directive('kbnSettingsIndices', function ($route, config, kbnUrl, indexPatterns, Private) {
return {
restrict: 'E',
transclude: true,
template: require('plugins/kibana/settings/sections/indices/directives/kbn_settings_indices.html'),
template: kbnSettingsIndicesTemplate,
link: function ($scope) {
const refreshKibanaIndex = Private(require('plugins/kibana/settings/sections/indices/_refresh_kibana_index'));
const refreshKibanaIndex = Private(PluginsKibanaSettingsSectionsIndicesRefreshKibanaIndexProvider);

$scope.showAddNew = !/^\/settings\/indices$/.test($route.current.$$route.originalPath);
$scope.editingId = $route.current.params.indexPatternId;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import modules from 'ui/modules';
import template from 'plugins/kibana/settings/sections/indices/filebeat/directives/filebeat_wizard.html';
import IngestProvider from 'ui/ingest';
import 'plugins/kibana/settings/sections/indices/add_data_steps/pattern_review_step';
import 'plugins/kibana/settings/sections/indices/add_data_steps/paste_samples_step';
import 'plugins/kibana/settings/sections/indices/add_data_steps/pipeline_setup';
import 'plugins/kibana/settings/sections/indices/add_data_steps/install_filebeat_step';

require('plugins/kibana/settings/sections/indices/add_data_steps/pattern_review_step');
require('plugins/kibana/settings/sections/indices/add_data_steps/paste_samples_step');
require('plugins/kibana/settings/sections/indices/add_data_steps/pipeline_setup');
require('plugins/kibana/settings/sections/indices/add_data_steps/install_filebeat_step');

// wrapper directive, which sets up the breadcrumb for all filebeat steps
modules.get('apps/settings')
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var routes = require('ui/routes');
var template = require('plugins/kibana/settings/sections/indices/filebeat/index.html');
import routes from 'ui/routes';
import template from 'plugins/kibana/settings/sections/indices/filebeat/index.html';
import 'plugins/kibana/settings/sections/indices/filebeat/directives/filebeat_wizard';

require('plugins/kibana/settings/sections/indices/filebeat/directives/filebeat_wizard');

routes.when('/settings/indices/create/filebeat', {
template: template
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const expect = require('expect.js');
const _ = require('lodash');
import processESIngestSimulateResponse from '../process_es_ingest_simulate_response';
import expect from 'expect.js';
import _ from 'lodash';

describe('processESIngestSimulateResponse', function () {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const _ = require('lodash');
import _ from 'lodash';

function translateError(esError) {
const rootCause = _.get(esError, 'root_cause[0]');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const Joi = require('joi');
const indexPatternSchema = require('./index_pattern_schema');
const pipelineSchema = require('./pipeline_schema');
import Joi from 'joi';
import indexPatternSchema from './index_pattern_schema';
import pipelineSchema from './pipeline_schema';

module.exports = Joi.object({
index_pattern: indexPatternSchema.required(),
Expand Down
10 changes: 7 additions & 3 deletions src/plugins/kibana/server/routes/api/ingest/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import { registerPost } from './register_post';
import { registerDelete } from './register_delete';
import { registerSimulate } from './register_simulate';

export default function (server) {
require('./register_post')(server);
require('./register_delete')(server);
require('./register_simulate')(server);
registerPost(server);
registerDelete(server);
registerSimulate(server);
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Promise from 'bluebird';
import handleESError from '../../../lib/handle_es_error';
import {ingestToPattern, patternToIngest} from '../../../../common/lib/convert_pattern_and_ingest_name';

module.exports = function registerDelete(server) {
export function registerDelete(server) {
server.route({
path: '/api/kibana/ingest/{id}',
method: 'DELETE',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {ingestToPattern, patternToIngest} from '../../../../common/lib/convert_p
import { keysToCamelCaseShallow } from '../../../../common/lib/case_conversion';
import ingestPipelineApiKibanaToEsConverter from '../../../lib/converters/ingest_pipeline_api_kibana_to_es_converter';

module.exports = function registerPost(server) {
export function registerPost(server) {
const kibanaIndex = server.config().get('kibana.index');

function patternRollback(rootError, indexPatternId, boundCallWithRequest) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import simulateRequestSchema from '../../../lib/schemas/simulate_request_schema'
import ingestSimulateApiKibanaToEsConverter from '../../../lib/converters/ingest_simulate_api_kibana_to_es_converter';
import { keysToCamelCaseShallow, keysToSnakeCaseShallow } from '../../../../common/lib/case_conversion';

module.exports = function registerSimulate(server) {
export function registerSimulate(server) {
server.route({
path: '/api/kibana/ingest/simulate',
method: 'POST',
Expand Down