-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Node Pipelines] Pipeline Processors Editor #66021
Merged
Merged
Changes from all commits
Commits
Show all changes
188 commits
Select commit
Hold shift + click to select a range
c19382d
initial plugin setup
alisonelizabeth bf94f1c
add smoke test
alisonelizabeth e24165e
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth b0bb193
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth 5a536bd
fix license check
alisonelizabeth ef2f1ab
refactor plugin setup
alisonelizabeth fc9235b
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine a841441
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine 7de73c8
Server-side create/update ingest pipelines (#62744)
alisonelizabeth ac0ac2b
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine 699ebef
List pipelines (#62785)
jloleysens 92b3f21
[Ingest pipelines] Create pipeline UI (#63017)
alisonelizabeth 993d065
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth 2b70fa7
First vertical slice of pipeline editor component
jloleysens 402459f
Made a space for common parameters
jloleysens cf8b36b
[Ingest pipelines] Edit pipeline page (#63522)
alisonelizabeth 3824e25
First iteration of CRUD functionality working
jloleysens 7d48f21
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
jloleysens f3f705f
WiP on moving the pipeline editor to pipeline processor editor
jloleysens 48a18c6
Finish refactor to work with passing state out
jloleysens 9e09ad5
Refactor and fix tests
jloleysens 8d18877
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth 7e7d776
[Ingest pipelines] Polish details panel and empty list (#63926)
alisonelizabeth 4560d75
Address some early feedback and use FormDataProvider
jloleysens 597b148
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
jloleysens 6ffaeda
[Ingest pipelines] Delete pipeline (#63635)
alisonelizabeth 2c340b2
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
jloleysens 34cb91a
[Ingest Node Pipelines] Clone Pipeline (#64049)
jloleysens 29b006b
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
jloleysens 564f74f
Update to using the more flexible controlled component pattern
jloleysens 9c0bd8e
Handle sub-form validity
jloleysens 82a999c
Fix Jest test
jloleysens be9a290
Refactor some names
jloleysens 2957970
Mark as private
jloleysens 736c98e
Major WiP
jloleysens eba5305
[Ingest node pipelines] Privileges (#63850)
jloleysens 74b69c7
First iteration of drag and drop tree on feature parity
jloleysens 8314d23
First steps toward add on failure handler
jloleysens 1141e50
First iteration of nested tree with add on failure working
jloleysens 5c84cc4
Refactor and some UI layout updates
jloleysens 09f74db
Remove immer (not call stack safe)
jloleysens dbc5cc5
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine a2b4049
[Ingest Node Pipelines] More lenient treatment of on-failure value (#…
jloleysens e40cefc
Move file to components folder
jloleysens cad13fd
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine fc0ed64
[Ingest pipelines] Simulate pipeline (#64223)
alisonelizabeth 6c71bff
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
jloleysens 0ef475c
Updated tree rendering
jloleysens 6dbdf06
[Ingest Node Pipelines] Show flyout after editing or creating a pipel…
jloleysens e7f1e3c
Clarification of terms
jloleysens b60ef5f
Implement move between lists functionality
jloleysens a9c5384
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth 5643419
fix TS
alisonelizabeth 61d194b
Prevent nesting a parent inside of its own child
jloleysens d9ef80a
Add comment
jloleysens f3a16f2
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine 7010b9e
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth 3c4353f
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine a4c298d
[Ingest pipelines] Cleanup (#64794)
alisonelizabeth 5bbb9fc
address review feedback
alisonelizabeth dd93b11
remove unused import
alisonelizabeth 3ccc16d
Big refactor to tree rendering structure
jloleysens b8b169f
Remove unused component
jloleysens 62b0f53
A number of NB changes
jloleysens a5bd69a
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
jloleysens 68c12f9
Merge branch 'master' of github.com:elastic/kibana into pipeline-edit…
jloleysens 3992a29
fix bad conflict resolution
jloleysens b88f703
Implemented a slightly better destination resolution algo.
jloleysens b05e356
Fix subtle staleness bug, whitelist keys for setValue
jloleysens f70165c
NB styling fix!!
jloleysens e6f9bd0
Fix stale delete bug too
jloleysens fb2733b
Update naming of editor modes and update comments
jloleysens 74221e4
Use field types combo box
jloleysens 53c42d9
Add delete confirmation modal
jloleysens 8617031
Refactor delete modal component file name
jloleysens d32b73c
Better visual integration with existing form
jloleysens 62b3277
Update layout and styling of form
jloleysens 9e1e698
Move pipeline processor copy into pipeline processor component
jloleysens d5b0e8a
First step of refactor to moving between trees
jloleysens 8e738a2
First iteration of x-tree drag and drop
jloleysens 39c8dbd
Remove unused import
jloleysens 1a63baf
Fix jest test types
jloleysens e6f4f74
Fix up minor i18n issues and fix up layout of on failure
jloleysens 830e9e9
Remove unnecessary prop
jloleysens 41613be
Update spacing above add processor button to make it more center
jloleysens c7fe2db
Merge branch 'master' of github.com:elastic/kibana into pipeline-edit…
jloleysens eff46b0
Fix destination resolution algo
jloleysens 0fcdd06
Update dragging resolver unit tests and add a lot more comments
jloleysens 49def41
Use one sorting algo (removed use of euiReorder for now)
jloleysens 698d8ff
Add placeholder tests and update comments
jloleysens 33fe79c
Merge branch 'master' into feature/pipeline-editor
elasticmachine b1eb94c
Quite a big refactor
jloleysens 7d632fc
Fix off by one bug in tests and implementation 🤦🏼♂
jloleysens b6f0042
Update behaviour for dragging up across trees and add tests
jloleysens 78b86ad
Fix combine instruction
jloleysens 6316956
Merge branch 'master' of github.com:elastic/kibana into feature/pipel…
jloleysens 1688711
Fix test and i18n issues
jloleysens 07b6df1
Remove background color
jloleysens bed0bf8
Fix selector after selector refactor
jloleysens 99fa8cd
A major performance
jloleysens 0f477f3
Fix component smoke test
jloleysens 1fdbf8a
Fix reading value from processor state using processor selector
jloleysens ce275fe
[Ingest pipelines] Custom processor form (#66022)
alisonelizabeth 40e6c71
Merge branch 'master' of github.com:elastic/kibana into feature/pipel…
jloleysens 6af236d
Re add background color and refactor name of processor item
jloleysens f00cfcf
Fix file naming and refactor 🚜 dnd tree rendering
jloleysens 9591de0
Fix getting of initial on failure processors value
jloleysens c1f62df
Update padding styles for containers
jloleysens 94096ea
A lot of styling updates to get closer to look of mockup
jloleysens f06f9e4
Merge branch 'master' of github.com:elastic/kibana into feature/pipel…
jloleysens edddeee
A WiP version of th click-tree an alternative to dnd
jloleysens 971e2e9
Remove dnd tree
jloleysens 2402cc8
Merge branch 'master' into feature/pipeline-editor
elasticmachine f2a20c8
clean up reamining dnd tree references
jloleysens b0387de
Clean up and refactor of tree component
jloleysens 8098fc9
Added the ability to duplicate a processor
jloleysens 5c5a932
Fix types in test
jloleysens d121586
Added duplicate functionality to ui
jloleysens 1afecdf
Memoize tree components
jloleysens e43c7a4
address es lint issues
jloleysens 626a61d
remove unused import
jloleysens 24afa02
Fix editing of custom json
jloleysens 58b79a5
Address form performance issues
jloleysens 9ffebad
Add all known missing processors
jloleysens 7caac48
Add ability to cancel move
jloleysens 1095aca
Fix staleness in test and view request flyouts
jloleysens da8fb67
fix type issue
jloleysens df4f70a
Remove unused translations and skip funcitonal test for now
jloleysens e1149bd
add todo comment
jloleysens 243185e
Fix type issues
jloleysens f646b78
remove poc styles
jloleysens e884ee2
disable other move buttons if we have a selected processor
jloleysens 180e73f
Refactor drop zone pin to button and add some styling
jloleysens 7e8de28
Refactor processor editor item
jloleysens fd8dbeb
Update styling and use icon for cancel move action too
jloleysens 64e06c0
fix nasty integration bug
jloleysens a7ee474
some minor optimizations
jloleysens 9420c87
prevent parent from being placed in own on failure handler
jloleysens 6aea902
Re-add cancel button
jloleysens 2003eb5
Re-introduce failure processors toggle
jloleysens bc091df
Fix typo
jloleysens cc66d65
Add Handler types for processor editor item
jloleysens 14c59b0
Fix staleness bug for type, refactor classname and fix duplicate
jloleysens 9844dee
Experimenting with padels (revert this to undo if no further
jloleysens 08247dd
Add description and unique ids
jloleysens edc7b6e
Share links via component-wide context rather than props
jloleysens d396be0
Merge branch 'master' into feature/pipeline-editor
elasticmachine 6a1234e
Virtualized list and back to outline dropzones
jloleysens c8ccb34
Refactor id getter to a service and make it an incrementing number
jloleysens f10e2d8
Temporary fix for double rendering issue.
jloleysens bff143e
add todo comment
jloleysens cc84437
remove euicode element
jloleysens 97089ab
properly handle duplicate flow
jloleysens 3cf7c9f
attempt to fix i18n
jloleysens bb21d75
split private_tree into it's own component and add comments
jloleysens 22c094a
refactor 🚜. rename Tree to ProcessorsTree and move things around
jloleysens 9267793
do not delete the top level arrays for processors and onfailures
jloleysens c5a5e4e
fix typescript error
jloleysens 791d9e6
Merge branch 'master' into feature/pipeline-editor
elasticmachine 0b71abe
Move duplicate, addOnFailure and delete actions into ctx menu
jloleysens 94a9c65
remove unused import
jloleysens fd2789f
add support for pressing esc key to cancel move
jloleysens 90fd933
Add outside click listener
jloleysens a25056a
always prompt before deleting a processor
jloleysens e51bf88
refactor remove distinction between adding top level and on fail
jloleysens 1a2b439
add processor button to tree
jloleysens ef2c745
Hide the add on failure context menu item for processors with
jloleysens 9ba6906
Reinstated x-tree moving and highlight and disable for buttons
jloleysens 1918b8b
removing ids step 1: remove idGenerator
jloleysens 9a5cf06
remove ids step 2: added inline text input
jloleysens d519513
Slight improvement to styling of text input (border)
jloleysens 8e78aea
Re-implement missing failure toggle test
jloleysens 4624337
address type todo
jloleysens 5ef85cd
Address many type issues and fix yarn.lock
jloleysens 4b05049
re-enable create pipeline functional test
jloleysens 4b26dd4
prevent multiple flyouts from opening
jloleysens 8b3e9f7
change flyout title when editing an on-failure processor
jloleysens ca2f8d5
absolutely position the failure handlers label
jloleysens 65fb5ff
fix description behaviour not removing tag if empty
jloleysens dcb23bd
some minor clean up
jloleysens a242aa7
add onflyoutopen cb to tests
jloleysens 73babef
Merge branch 'master' into feature/pipeline-editor
elasticmachine 1419d3b
Merge branch 'master' into feature/pipeline-editor
elasticmachine 634f9d0
refactor processors editor item to multiple files
jloleysens 7db7f3e
Merge branch 'master' into feature/pipeline-editor
elasticmachine ec77c7d
fix add on-failure handler in context menu after refactor
jloleysens 7e91996
Merge branch 'master' into feature/pipeline-editor
elasticmachine a3d0dc8
tag -> new description field
jloleysens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these URLs ever change? I'm surprised to see them being passed as props, but then I don't know what the convention is in Kibana.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, they change based on the version of stack you are running. So if you are on v7.7.0 all links to docs should send you to the correct v7.7.0 docs.
The idea with passing them in as props here is so that this component can be moved out of the ingest pipelines editor in future without depending on plugin specific ways of sharing these values like context or services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Cloud UI has a docs "service" of sorts, which defines a map of doc links, and then renders links using config to control the docs version. I'm not suggested you implement that, just sharing 😅