Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a "Less Info" button to toast messages #6540

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

bevacqua
Copy link
Contributor

Fixes #5190.

@tsullivan
Copy link
Member

@bevacqua sorry but I'm not super familiar with how to cause a toast message to show. Can you document some steps?

@tsullivan tsullivan assigned bevacqua and unassigned tsullivan Mar 15, 2016
@bevacqua
Copy link
Contributor Author

# tab 1
npm run elasticsearch
# tab 2
npm start
# open up kibana, wait until it loads
# tab 1
^C
# navigate to Visualize

You should see the toast

@bevacqua bevacqua assigned tsullivan and unassigned bevacqua Mar 15, 2016
@tsullivan
Copy link
Member

Ah thanks. I got it showing by going from Discover to Visualize then back to Discover.

LGTM

@tsullivan tsullivan assigned bevacqua and unassigned tsullivan Mar 15, 2016
@bevacqua bevacqua assigned rashidkpc and unassigned bevacqua Mar 15, 2016
@bevacqua
Copy link
Contributor Author

@rashidkpc If you could just take a look.

@rashidkpc
Copy link
Contributor

LGTM

rashidkpc pushed a commit that referenced this pull request Mar 15, 2016
Added a "Less Info" button to toast messages
@rashidkpc rashidkpc merged commit f5b2a9c into elastic:master Mar 15, 2016
@bevacqua bevacqua deleted the feature/less-toast-info branch March 16, 2016 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants