-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Deprecate MlInMemoryTable. #65039
[ML] Deprecate MlInMemoryTable. #65039
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although a pity that sorting on the score column is not working! Needs following up with the EUI team. One alternative in the meantime, would be to move the info tooltip about the score outside of the table header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM ⚡
@peteharverson @alvarezmelissa87 |
@walterra there are links from the job IDs in the jobs list in the Stack Management page back to the DFA jobs list in the ML plugin, which pass the job ID in the URL, in the form
Is this what the code you mentioned in #65039 (comment) is used for? |
@peteharverson Thanks for the hint, I tested the links and navigation from the job id in Kibana management to the filtered analytics job list within the ML worked for me! |
💚 Build SucceededBuild metricsasync chunks size
miscellaneous assets size
page load bundle size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM
Now that EUI is fully migrated to TypeScript, we can remove our own typed version of InMemoryTable. # Conflicts: # x-pack/plugins/ml/public/application/components/ml_in_memory_table/types.ts
Summary
Now that EUI is fully migrated to TypeScript, we can remove our own typed version of InMemoryTable.
Review note for
kibana-design
: This one just removes a no longer necessary custom CSS class.Checklist
Delete any items that are not applicable to this PR.
Unit or functional tests were updated or added to match the most common scenariosRefactor only, existing tests need to pass.
For maintainers