Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style dashboard buttons the same way #63403

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Style dashboard buttons the same way #63403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12c91e1
Stylize dashboard buttons the same way
ryankeairns Apr 13, 2020
6e8c5c3
update snapshots
ryankeairns Apr 13, 2020
1490cc4
Merge branch 'master' into rk/62070-dashboard-buttons
elasticmachine Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/plugins/dashboard/public/application/__snapshots__/dashboard_empty_screen.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 1 addition & 9 deletions src/plugins/dashboard/public/application/_dashboard_app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,10 @@

.dshEmptyWidget {
border: $euiBorderThin;
border-style: dashed;
border-style: dashed;
border-radius: $euiBorderRadius;
padding: $euiSizeXXL * 2;
max-width: 400px;
margin-left: $euiSizeS;
text-align: center;
}

.dshEmptyWidget {
border: 2px dashed $euiColorLightShade;
padding: 4 * $euiSize;
max-width: 20em;
margin-left: 10px;
text-align: center;
}
5 changes: 2 additions & 3 deletions src/plugins/dashboard/public/application/dashboard_empty_screen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,9 @@ export function DashboardEmptyScreen({
const linkToVisualizeParagraph = (
<p data-test-subj="linkToVisualizeParagraph">
<EuiButton
iconSide="right"
iconSide="left"
size="s"
fill
iconType="arrowDown"
iconType="plusInCircle"
onClick={onVisualizeClick}
data-test-subj="addVisualizationButton"
aria-label={constants.createNewVisualizationButtonAriaLabel}
Expand Down
4 changes: 2 additions & 2 deletions .../public/lib/panel/panel_header/panel_actions/add_panel/saved_object_finder_create_new.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export function SavedObjectFinderCreateNew({ menuItems }: Props) {
button={
<EuiButton
data-test-subj="createNew"
iconType="arrowDown"
iconSide="right"
iconType="plusInCircle"
iconSide="left"
onClick={toggleCreateMenu}
fill
>
Expand Down
5 changes: 0 additions & 5 deletions src/plugins/navigation/public/top_nav_menu/__snapshots__/top_nav_menu_item.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/plugins/navigation/public/top_nav_menu/top_nav_menu_item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function TopNavMenuItem(props: TopNavMenuData) {
};

const btn = props.emphasize ? (
<EuiButton {...commonButtonProps} size="s" fill style={{ fontSize: 'smaller' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

<EuiButton {...commonButtonProps} size="s" fill>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this to size "S" increases the height of the nav row and also creates a weird visual effect when switching edit mode on and off. Is that OK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Devon's original PR (adding this button) we accepted the height change between view and edit modes. This particular change here only affects the font-size and has no impact on the overall button height.

This situation will be addressed when we move to the new header design where the menus are anticipated to move up into the header area - the plan as of now is for a double header, like GitHub, and will better accommodate buttons in the menu layout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizozom given that explanation, can you approve this PR? Thanks!

{capitalize(props.label || props.id!)}
</EuiButton>
) : (
Expand Down