Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip functional tests for field visualize buttons #62614

Merged
merged 27 commits into from
Apr 22, 2020
Merged

[Discover] Unskip functional tests for field visualize buttons #62614

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ca8965b
Unskip test
kertal Apr 2, 2020
12fdaba
Add visualize button test in OSS
kertal Apr 3, 2020
3e9b076
Remove other discover tests
kertal Apr 4, 2020
e55fdde
Implement retry for flaky tests
kertal Apr 5, 2020
9e3e00a
Remove before code that failed
kertal Apr 6, 2020
afc9ff3
Improve retry code
kertal Apr 6, 2020
f1ee00f
Apply fix to discover security and spaces
kertal Apr 6, 2020
021c32d
Merge upstream/master, fix conflicts
kertal Apr 6, 2020
ff5895e
Undo _discover.js changes
kertal Apr 6, 2020
0088147
Add missing retry service to discover_security.ts
kertal Apr 6, 2020
d318d32
Fix security bugs
kertal Apr 6, 2020
f95faa7
Merge branch 'master' into kertal-pr-2020-04-02-discover-unskip-field…
elasticmachine Apr 10, 2020
e73cd0b
Adapt tests to use PageObjects.discover.getHitCount()
kertal Apr 16, 2020
d9737d3
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal Apr 16, 2020
d11190d
Merge branch 'kertal-pr-2020-04-02-discover-unskip-field-visualize-fu…
kertal Apr 16, 2020
8cff5ef
fix tests that expect the visualize button not to exist
kertal Apr 16, 2020
1a368b3
Add debugging
kertal Apr 17, 2020
49974e4
Increase waitForCompletionTimeout to 5s
kertal Apr 17, 2020
a50a210
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal Apr 18, 2020
cc76e78
Undo test adaptions
kertal Apr 18, 2020
1986411
Modify async search code
kertal Apr 22, 2020
6688d68
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal Apr 22, 2020
51f52bc
undo wait for completion timeout setting too 5s
kertal Apr 22, 2020
ba1dbbf
resolves #64132
Apr 22, 2020
c6688fb
simplify condition
Apr 22, 2020
934db8e
Merge async fix
kertal Apr 22, 2020
63aa5df
Merge upstream/master, fix conflicts
kertal Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions x-pack/test/functional/apps/discover/feature_controls/discover_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const retry = getService('retry');
const security = getService('security');
const globalNav = getService('globalNav');
const config = getService('config');
Expand All @@ -28,8 +29,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.timePicker.setDefaultAbsoluteRange();
}

// FLAKY: https://github.com/elastic/kibana/issues/60535
describe.skip('security', () => {
describe('security', () => {
before(async () => {
await esArchiver.load('discover/feature_controls/security');
await esArchiver.loadIfNeeded('logstash_functional');
Expand Down Expand Up @@ -186,8 +186,12 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
it(`doesn't show visualize button`, async () => {
await PageObjects.common.navigateToApp('discover');
await setDiscoverTimeRange();
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectMissingFieldListItemVisualize('bytes');
await retry.try(async () => {
const hitCount = await PageObjects.discover.getHitCount();
expect(parseInt(hitCount, 10)).to.be.greaterThan(0);
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectMissingFieldListItemVisualize('bytes');
});
});

it(`Permalinks doesn't show create short-url button`, async () => {
Expand Down Expand Up @@ -275,8 +279,12 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
it(`doesn't show visualize button`, async () => {
await PageObjects.common.navigateToApp('discover');
await setDiscoverTimeRange();
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectMissingFieldListItemVisualize('bytes');
await retry.try(async () => {
const hitCount = await PageObjects.discover.getHitCount();
expect(parseInt(hitCount, 10)).to.be.greaterThan(0);
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectMissingFieldListItemVisualize('bytes');
});
});

it('Permalinks shows create short-url button', async () => {
Expand Down Expand Up @@ -352,8 +360,12 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
it(`shows the visualize button`, async () => {
await PageObjects.common.navigateToApp('discover');
await setDiscoverTimeRange();
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectFieldListItemVisualize('bytes');
await retry.try(async () => {
const hitCount = await PageObjects.discover.getHitCount();
expect(parseInt(hitCount, 10)).to.be.greaterThan(0);
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectFieldListItemVisualize('bytes');
});
});
});

Expand Down
20 changes: 14 additions & 6 deletions x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const config = getService('config');
const spacesService = getService('spaces');
const retry = getService('retry');
const PageObjects = getPageObjects([
'common',
'discover',
Expand All @@ -24,8 +25,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.timePicker.setDefaultAbsoluteRange();
}

// FLAKY: https://github.com/elastic/kibana/issues/60559
describe.skip('spaces', () => {
describe('spaces', () => {
before(async () => {
await esArchiver.loadIfNeeded('logstash_functional');
});
Expand Down Expand Up @@ -69,8 +69,12 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
basePath: '/s/custom_space',
});
await setDiscoverTimeRange();
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectFieldListItemVisualize('bytes');
await retry.try(async () => {
const hitCount = await PageObjects.discover.getHitCount();
expect(parseInt(hitCount, 10)).to.be.greaterThan(0);
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectFieldListItemVisualize('bytes');
});
});
});

Expand Down Expand Up @@ -135,8 +139,12 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
basePath: '/s/custom_space',
});
await setDiscoverTimeRange();
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectMissingFieldListItemVisualize('bytes');
await retry.try(async () => {
const hitCount = await PageObjects.discover.getHitCount();
expect(parseInt(hitCount, 10)).to.be.greaterThan(0);
await PageObjects.discover.clickFieldListItem('bytes');
await PageObjects.discover.expectMissingFieldListItemVisualize('bytes');
});
});
});

Expand Down