Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ScopedHistory.createHref to prepend location with scoped history basePath #62407

Merged
merged 14 commits into from
Apr 11, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test plugins urls
  • Loading branch information
pgayvallet committed Apr 7, 2020
commit abd75e1b0298e93db51072dadb79e072f56f5715
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const Nav = withRouter(({ history, navigateToApp }: NavProps) => (
{
id: 'home',
name: 'Home',
onClick: () => history.push('/'),
onClick: () => history.push(''),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prependBasePathToString was incorrectly removing the trailing /, as this is fixed, I adapted the test plugins instead or changing every waitForUrlToBe('/app/foo'); to waitForUrlToBe('/app/foo/'); in test/plugin_functional/test_suites/core_plugins/applications.ts

'data-test-subj': 'fooNavHome',
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const Nav = withRouter(({ history, navigateToApp }: NavProps) => (
{
id: 'home',
name: 'Home',
onClick: () => navigateToApp('bar', { path: '/' }),
onClick: () => navigateToApp('bar', { path: '' }),
'data-test-subj': 'barNavHome',
},
{
Expand Down