-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ScopedHistory.createHref to prepend location with scoped history basePath #62407
Merged
pgayvallet
merged 14 commits into
elastic:master
from
pgayvallet:kbn-62016-createhref-basepath
Apr 11, 2020
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dc8dc7f
fix createHref to prepend with scoped history basePath + add option t…
pgayvallet 460ec47
Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…
pgayvallet 460abe1
fix prependBasePath behavior
pgayvallet b6c2107
Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…
pgayvallet abd75e1
fix test plugins urls
pgayvallet 3762fde
Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…
pgayvallet ab763a3
Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…
pgayvallet 7604932
add pathname to endpoint url builder methods
pgayvallet eff1faf
Revert "add pathname to endpoint url builder methods"
pgayvallet e4b8eeb
adapt createHref instead of prependBasePath
pgayvallet 737c5df
Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…
pgayvallet 052cdea
Merge remote-tracking branch 'upstream/master' into kbn-62016-createh…
pgayvallet 353277d
use object options for createHref
pgayvallet 1fb7fc6
update generated doc
pgayvallet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix test plugins urls
- Loading branch information
commit abd75e1b0298e93db51072dadb79e072f56f5715
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prependBasePathToString
was incorrectly removing the trailing/
, as this is fixed, I adapted the test plugins instead or changing everywaitForUrlToBe('/app/foo');
towaitForUrlToBe('/app/foo/');
intest/plugin_functional/test_suites/core_plugins/applications.ts