-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Upgrade" badge on disabled action types in the create connector flyout #61111
Remove "Upgrade" badge on disabled action types in the create connector flyout #61111
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cards endup having different heights, I wonder if @andreadelrio found a workaround for this as she also noticed the issue when no betaBadgeLabel was defined.
TIL, the badge was there to solve the height differences issue. I'm looking for alternatives:
|
…pgrade-license-budge # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_menu.test.tsx
If have the banner on top with the appropriate CTA (#60698), then it should be self explanatory as to why they are not available / disabled / [whatever text we choose] |
Fix height of disabled cards
PR to just add some css that fixes the height issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, LGTM!
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…or flyout (elastic#61111) * Remove "Upgrade" badge on disabled action types in the create connector flyout * Fix height of disabled cards Co-authored-by: defazio <michael.defazio@elastic.co>
Resolve #60765