[Metrics Alerts] Fix error when a metric reports no data #59810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
phillipb
suggested changes
Mar 10, 2020
| const { buckets } = aggregations.aggregatedIntervals; | ||
| const { value } = buckets[buckets.length - 1].aggregatedValue; | ||
| return value; | ||
| try { |
There was a problem hiding this comment.
Out of curiosity, why the try/catch here. Why not just explicit if (!buckets.length)? Not a huge deal, but I'm afraid that intent is lost with try/catch.
There was a problem hiding this comment.
Fair enough, figured we wanted to guard for any error in retrieving the data but I'll see if I can clarify
phillipb
approved these changes
Mar 10, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 11, 2020
* master: [Metrics Alerts] Fix error when a metric reports no data (elastic#59810) Vislib legend toggle broken (elastic#59736) [RFC] Pulse (elastic#57108)
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Mar 11, 2020
* [Metrics Alerts] Fix error when a metric reports no data * Clarify no data case handler, add separate error state * Throw error state when callCluster fails
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Zacqary
added a commit
that referenced
this pull request
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59809
Adds a
NO_DATAalert state possibility, and sets this state if the alert can't find data over the specified lookup interval.