-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define minimum license required for each action type #58668
Changes from 9 commits
81d08d7
902bdec
76948d4
ac0d3e8
db039f7
07e0d88
a24caa0
44fb539
44158c3
c87435b
deb7621
b6d5c0e
af432ef
9669ebd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,7 @@ export function getActionType({ | |
}): ActionType { | ||
return { | ||
id: '.servicenow', | ||
minimumLicenseRequired: 'gold', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mikecote @peterschretlen I just spoke with @MikePaquette, can we make this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, I went ahead and made it |
||
name: i18n.translate('xpack.actions.builtin.servicenowTitle', { | ||
defaultMessage: 'ServiceNow', | ||
}), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe there's an hook later, but this seems to violate "non-built-in action types can only set a gold+ license"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set anything here but it will be validated when you register. The registration validation exists here: https://github.com/elastic/kibana/pull/58668/files#diff-adc6606fd00ebc8b46eecefae314f1b5R187 and the built ins don't go through there, they register directly to the
actionTypeRegistry
.