[SIEM][CASE][skip-ci] Connectors flyout #58632

cnasikas · 2020-02-26T18:53:56Z

Summary

The PR adds the Connector's flyout in Cases Configuration Page.

Code from eed3183 is taken from #58514. Will be removed when #58514 merges with master.
Depends on: #58121 , #58514
Issues: #58530, #57864 , #50103

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-02-26T18:53:58Z

Pinging @elastic/siem (Team:SIEM)

cnasikas · 2020-02-27T15:53:18Z

@elasticmachine merge upstream

kibanamachine · 2020-02-28T20:43:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 6029498363a736a204807a3cc263b6bc32e02696

Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/spaces/server/lib/request_interceptors.onRequestInterceptor requests proxied to the legacy platform handles paths without a space identifier

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

: Timeout - Async callback was not invoked within the 30000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 30000ms timeout specified by jest.setTimeout.Error: 
    at new Spec (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
    at new Spec (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/setup_jest_globals.js:80:9)
    at specFactory (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:575:24)
    at Env.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:644:24)
    at Env.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:132:23)
    at it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:93:21)
    at Suite.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/spaces/server/lib/request_interceptors/on_request_interceptor.test.ts:129:5)
    at addSpecsToSuite (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:496:51)
    at Env.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:466:11)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:81:18)
    at Suite.Object.<anonymous>.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/spaces/server/lib/request_interceptors/on_request_interceptor.test.ts:128:3)
    at addSpecsToSuite (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:496:51)
    at Env.describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/Env.js:466:11)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:81:18)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/spaces/server/lib/request_interceptors/on_request_interceptor.test.ts:21:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:867:68)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:577:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:433:10)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:202:13
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:27:24)
    at _next (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:47:9)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:52:7
    at new Promise (<anonymous>)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:44:12
    at jasmine2 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/index.js:60:19)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:385:24
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:161:24)
    at _next (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:181:9)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/spaces/server/lib/request_interceptors.onRequestInterceptor requests proxied to the legacy platform strips the Space URL Context from the request

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: Http server is not setup up yet
    at HttpServer.start (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/core/server/http/http_server.ts:142:13)
    at HttpService.start (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/core/server/http/http_service.ts:134:29)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form.connector_add_flyout renders action type menu on flyout open

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Cannot read property 'siem' of undefined
    at hasSaveActionsCapability (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/triggers_actions_ui/public/application/lib/capabilities.ts:35:20)
    at ConnectorAddFlyout (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.tsx:75:19)
    at renderWithHooks (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:16260:18)
    at mountIndeterminateComponent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:18794:13)
    at beginWork$1 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:20162:16)
    at HTMLUnknownElement.callCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at invokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
    at HTMLUnknownElementImpl._dispatch (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)
    at HTMLUnknownElement.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:143:21)
    at Object.invokeGuardedCallbackDev (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at beginWork$$1 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25780:7)
    at performUnitOfWork (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24698:12)
    at workLoopSync (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24671:22)
    at performSyncWorkOnRoot (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24270:11)
    at scheduleUpdateOnFiber (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:23698:7)
    at updateContainer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27103:3)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27528:7
    at unbatchedUpdates (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24433:12)
    at legacyRenderSubtreeIntoContainer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27527:5)
    at Object.render (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27608:10)
    at fn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:437:26)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:354:37
    at batchedUpdates$1 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24386:12)
    at Object.act (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1092:14)
    at wrapAct (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:354:13)
    at Object.render (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:423:16)
    at new ReactWrapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme/src/ReactWrapper.js:115:16)
    at mount (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme/src/mount.js:10:10)
    at mountWithIntl (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/test_utils/enzyme_helpers.tsx:92:10)
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.test.tsx:73:21)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)

and 1 more failures, only showing the first 3.

History

💔 Build #29686 failed 7a70539a13e82f8ce866dedc0834df2da023a705
💔 Build #29445 failed 6be1f06680b30adc3829153670eae361dabfe1ec
💔 Build #29233 failed 9ad27f68171bee773cc3a3dc0fd56ce15cf4ec2c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cnasikas · 2020-03-09T10:17:23Z

Closed in favor of #59358

cnasikas added WIP Work in progress Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 in progress labels Feb 26, 2020

cnasikas changed the title ~~[SIEM][CASE] Connectors flyout~~ [SIEM][CASE] [skip-ci] Connectors flyout Feb 26, 2020

cnasikas force-pushed the connectors_flyout branch 2 times, most recently from 8ef5f4e to ecc7c29 Compare February 27, 2020 15:22

cnasikas changed the title ~~[SIEM][CASE] [skip-ci] Connectors flyout~~ [SIEM][CASE] Connectors flyout Feb 27, 2020

cnasikas removed WIP Work in progress in progress labels Feb 27, 2020

cnasikas marked this pull request as ready for review February 27, 2020 15:49

cnasikas requested a review from a team as a code owner February 27, 2020 15:49

cnasikas force-pushed the connectors_flyout branch 2 times, most recently from 7a70539 to 6029498 Compare February 28, 2020 19:22

cnasikas changed the title ~~[SIEM][CASE] Connectors flyout~~ [SIEM][CASE][skip-ci] Connectors flyout Feb 28, 2020

cnasikas force-pushed the connectors_flyout branch from 6029498 to 37afe9f Compare March 1, 2020 11:54

cnasikas added 9 commits March 6, 2020 11:11

Refactor structure

7a47cf5

Init ServiceNow class

4e940c1

Add constants

3d098d3

Add configuration scheme

58f6fd2

Refactor configuration schema

82fae42

Refactor parameters schema

8ef660a

Create new types

4e710ad

Add supported source fields

91a85a6

Create helpers

5af92be

cnasikas added 27 commits March 6, 2020 11:11

Refactor response

389ae3d

Test helpers

bf87ebe

Remove unnecessary validation

6e75fac

Fix validation errors

66ce060

Throw error for unsupported actions

33f3d6e

Create mock incident

700d82c

Test executor

b5d95f7

Test ServiceNow lib

6998d8f

Convert to camelCase

e392650

Remove caller_id

9ff7184

Refactor helpers

d7afa1b

Refactor schema

d044981

Remove executorAction

9c9b25e

Test action handlers

4ad2fdd

Refactor tests

bfbbc3f

Create and update comments

9535eaa

Create servicenow connector

d8eebee

Register servicenow connector

c76dc04

Add ServiceNow logo

ac7afa3

Create connnectors mapping

512698e

Create validators in utils

3c1ab93

Use validators in connectors

e29a9a4

Validate URL

baa8481

Use connectors from config

379e693

Enable triggers_aciton_ui plugin

83523db

Show flyout

7e42a5d

Add closures options

6449515

cnasikas force-pushed the connectors_flyout branch from 37afe9f to 6449515 Compare March 6, 2020 15:18

cnasikas closed this Mar 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM][CASE][skip-ci] Connectors flyout #58632

[SIEM][CASE][skip-ci] Connectors flyout #58632

cnasikas commented Feb 26, 2020 •

edited

Loading

elasticmachine commented Feb 26, 2020

cnasikas commented Feb 27, 2020

kibanamachine commented Feb 28, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

cnasikas commented Mar 9, 2020

[SIEM][CASE][skip-ci] Connectors flyout #58632

[SIEM][CASE][skip-ci] Connectors flyout #58632

Conversation

cnasikas commented Feb 26, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Feb 26, 2020

cnasikas commented Feb 27, 2020

kibanamachine commented Feb 28, 2020

💔 Build Failed

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

History

cnasikas commented Mar 9, 2020

cnasikas commented Feb 26, 2020 •

edited

Loading