Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Adds clone feature to transforms list. #57837

Merged
merged 8 commits into from
Feb 21, 2020
Merged

[ML] Transforms: Adds clone feature to transforms list. #57837

merged 8 commits into from
Feb 21, 2020

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Feb 18, 2020 •
edited
Loading

Summary

Fixes #58344.

Adds a Clone action to the transform management list. The action opens the transform wizard with prepopulated configurations based on the selected transform. The fields for the transform name and target index will not be populated to avoid the obvious "already exists" warnings.

Checklist

For maintainers

@walterra walterra requested a review from a team as a code owner February 18, 2020 12:27
@walterra walterra self-assigned this Feb 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos mentioned this pull request Feb 19, 2020
Merged
alvarezmelissa87
alvarezmelissa87 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a test and LGTM ⚡️

darnautov
darnautov approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor suggestions

x-pack/legacy/plugins/transform/public/app/lib/kibana/common.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/transform/public/app/lib/kibana/kibana_context.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/transform/public/app/sections/clone_transform/clone_transform_section.tsx Show resolved Hide resolved
x-pack/legacy/plugins/transform/public/app/sections/clone_transform/clone_transform_section.tsx Show resolved Hide resolved
...s/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx Outdated
agg: agg as PIVOT_SUPPORTED_AGGS,
aggName,
dropDownName: aggName,
...aggConfig[agg],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think spread should always be on top, to be sure you override the values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c5ae56a.

...s/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx Outdated Show resolved Hide resolved
@walterra walterra requested a review from darnautov February 21, 2020 11:47
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 96000fa into elastic:master Feb 21, 2020
@walterra walterra deleted the ml-transform-clone branch February 21, 2020 14:32
@walterra walterra mentioned this pull request Feb 21, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Feb 21, 2020
@walterra
[ML] Transforms: Adds clone feature to transforms list. (elastic#57837)
d115293 
Adds a Clone action to the transform management list. The action opens the transform wizard with prepopulated configurations based on the selected transform. The fields for the transform name and target index will not be populated to avoid the obvious "already exists" warnings.
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 21, 2020
@mbondyra
Merge commit '02efb01c481f9f24d8d707f06dfc68b2fb805001' into IS-27405…
2ffa278 
…_improve-advanced-settings-save

* commit '02efb01c481f9f24d8d707f06dfc68b2fb805001': (43 commits)
  [Endpoint] Add a flyout to alert list. (elastic#57926)
  Make sure index pattern has fields before parsing (elastic#58242)
  Sanitize workpad before sending to API (elastic#57704)
  [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015)
  [Endpoint] Refactor Management List Tests (elastic#58148)
  [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176)
  Do not refresh color scale on each lookup (elastic#57792)
  Updating to @elastic/lodash@3.10.1-kibana4 (elastic#54662)
  Trigger context (elastic#57870)
  [ML] Transforms: Adds clone feature to transforms list. (elastic#57837)
  [ML] New Platform server shim: update fields service routes (elastic#58060)
  [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038)
  document difference between log record formats (elastic#57798)
  Expose elasticsearch config schema (elastic#57655)
  [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130)
  [SIEM] Cleans Cypress tests code (elastic#58134)
  fix: 🐛 make dev server Storybook builds work again (elastic#58188)
  Prevent core savedObjects plugin from being overridden (elastic#58193)
  Expose serverBasePath on client-side (elastic#58070)
  Fix legend sizing on area charts (elastic#58083)
  ...
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 22, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 24, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ua/chore/move…
73c6267 
…-out-of-legacy

* 'master' of github.com:elastic/kibana:
  [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936)
  [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128)
  Use EuiTokens for ES field types (elastic#57911)
  Added UI support for the default action group for Alert Type Model (elastic#57603)
  force savedObject API consumers to define SO type explicitly (elastic#58022)
  Update dependency @elastic/charts to ^17.1.1 (elastic#57634)
  [Endpoint] Add a flyout to alert list. (elastic#57926)
  Make sure index pattern has fields before parsing (elastic#58242)
  Sanitize workpad before sending to API (elastic#57704)
  [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015)
  [Endpoint] Refactor Management List Tests (elastic#58148)
  [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176)
  Do not refresh color scale on each lookup (elastic#57792)
  Updating to @elastic/lodash@3.10.1-kibana4 (elastic#54662)
  Trigger context (elastic#57870)
  [ML] Transforms: Adds clone feature to transforms list. (elastic#57837)
  [ML] New Platform server shim: update fields service routes (elastic#58060)
  [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038)
walterra added a commit that referenced this pull request Feb 24, 2020
@walterra
[ML] Transforms: Adds clone feature to transforms list. (#57837) (#58223
35f8728 
)

Adds a Clone action to the transform management list. The action opens the transform wizard with prepopulated configurations based on the selected transform. The fields for the transform name and target index will not be populated to avoid the obvious "already exists" warnings.
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 24, 2020
@walterra walterra mentioned this pull request Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@walterra walterra

Labels
Feature:Transforms ML transforms :ml release_note:enhancement v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Transfroms: Add ability to clone transform.
5 participants
@walterra @elasticmachine @kibanamachine @darnautov @alvarezmelissa87