Increase stability when initializing the Elasticsearch index for the event log #57465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d at the same time
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Closed
pmuellr
approved these changes
Feb 12, 2020
| } | ||
|
|
||
| public async indexDocument(doc: any): Promise<void> { | ||
| await this.callEs('index', doc); |
There was a problem hiding this comment.
interesting that we don't need a result here!
|
|
||
| interface AddTemplateOpts { | ||
| ilmExists: boolean; | ||
| await steps.createIlmPolicyIfNotExists(); |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Feb 14, 2020
…event log (elastic#57465) * Fix ILM policy creation * Handle errors thrown in scenario multiple Kibana instances are started at the same time * Fix tests and cleanup * Start adding tests * Refactor tests, add index template failure test * Create cluster client adapter to facilitate testing and isolation * Fix places calling callEs still Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote
added a commit
that referenced
this pull request
Feb 18, 2020
…event log (#57465) (#57731) * Fix ILM policy creation * Handle errors thrown in scenario multiple Kibana instances are started at the same time * Fix tests and cleanup * Start adding tests * Refactor tests, add index template failure test * Create cluster client adapter to facilitate testing and isolation * Fix places calling callEs still Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first part of #55639, this PR increases the stability when initializing Elasticsearch by handling scenarios where multiple Kibana instances try to do the same thing at the same time.
It currently checks existence before creating ILM policy, index template and the initial index but there's a chance two Kibana instances see no existence and try to create them at the same time. This PR will solve these scenarios and swallow errors in those cases in order to move on with the setup phase instead of failing to setup.