Create observability CODEOWNERS reference #57109
Conversation
.github/CODEOWNERS
Outdated
| /x-pack/legacy/plugins/integrations_manager/ @elastic/epm | ||
| /x-pack/plugins/observability/ @elastic/logs-metrics-ui @elastic/apm-ui @elastic/uptime @elastic/epm |
There was a problem hiding this comment.
@elastic/epm should be @elastic/ingest (we're in the process of cleaning up the duplicate team labels after the reorg 🙂, but ingest should be the one to go with)
There was a problem hiding this comment.
Yeah but @jen-huang can you let me know what the team name will be next week too, so I can pre-emptively update to that? 🥁 🎤
How frequent do we anticipate changes to this plugin? I like the idea that this would ensure at least some involvement from all the teams. |
I'd expect them to be fairly infrequent, as far as I know. |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* master: (27 commits) Include actions new platform plugin for codeowners (elastic#57252) [APM][docs] 7.6 documentation updates (elastic#57124) Expressions refactor (elastic#54342) [ML] New Platform server shim: update annotation routes to use new platform router (elastic#57067) Remove injected ui app vars from Canvas (elastic#56190) update max_anomaly_score route schema to handle possible undefined values (elastic#57339) [Add panel flyout] Moving create new to the top of SavedObjectFinder (elastic#56428) Add mock of a legacy ui api to re-enable Canvas storybook (elastic#56673) [monitoring] Removes noisy event received log (elastic#57275) Remove use of copied MANAGEMENT_BREADCRUMBS and use `setBreadcrumbs` from management section's mount (elastic#57324) Advanced Settings management app to kibana platform plugin (elastic#56931) [ML] New Platform server shim: update recognize modules routes to use new platform router (elastic#57206) [ML] Fix overall stats for saved search on the Data Visualizer page (elastic#57312) [ML] [NP] Removing ui imports (elastic#56358) [SIEM] Fixes failing Cypress tests (elastic#57202) Create observability CODEOWNERS reference (elastic#57109) fix results service schema (elastic#57217) don't register a wrapper if browser side function exists. (elastic#57196) Ui Actions explorer example (elastic#57006) Fix update alert API to still work when AAD is out of sync (elastic#57039) ...
Summary
Adds new platform folder for infra plugin CODEOWNERS line, as well as a line for the NP observability plugin, which pings all of the observability UI teams.
This means we need someone from each of those UI teams to approve changes to this folder, but I think that may be a good idea? If we made a singe observability UI team we were all members of, it would only take one approval to get changes through which may mean other teams miss changes to our shared folder.