-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Add functional test to cover more filter functionality #56794
[Uptime] Add functional test to cover more filter functionality #56794
Conversation
Pinging @elastic/uptime (Team:uptime) |
672f4b1
to
21d41de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great add!
const esService = getService('legacyEs'); | ||
await makeChecksWithStatus(esService, MONITOR_ID, 5, 2, 10000, {}, 'up', mogrifyNoLocation); | ||
await makeChecksWithStatus(esService, 'filter-testing', 50, 1, 10000, {}, 'up', (d: any) => { | ||
d.observer.geo.name = 'filter-test'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe specify the geo name with a variable so we don't have to repeat this string value below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 0a3f970.
await pageObjects.uptime.selectFilterItems({ location: ['filter-test'] }); | ||
await retry.tryForTime(12000, async () => { | ||
const snapshotCount = await pageObjects.uptime.getSnapshotCount(); | ||
expect(snapshotCount).to.eql({ up: '1', down: '0' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any sort of test we could do on the ping histogram to catch breakage there? Looking around I don't see anything super obvious to hook into.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ustinkambic/kibana into uptime_functional-test-filter-snapshot
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/locations·ts.Uptime app with generated data location adds a second location filter option and filters the overviewStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/locations·ts.Uptime app with generated data location adds a second location filter option and filters the overviewStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/locations·ts.Uptime app with generated data location adds a second location filter option and filters the overviewStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
We aren't in the process of adding any additional functional tests at the moment. |
Summary
Related to #56766.
We recently discovered that our functional test suite failed to catch a nasty bug where, when filters were applied to the page the snapshot component breaks.
This patch is designed to add a test that will catch this in the future.
It's WIP for now until the fix commit is merged tomaster
.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers