Don't bother setting the number of index replicas when creating kibana-int #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
Before we can review this we'll need you to sign the CLA. Please check out CONTRIBUTING.md |
|
Just signed the CLA. Now what? |
|
Confirmed, the CLA has been signed |
|
jenkins, test it |
| @@ -70,8 +70,6 @@ describe('plugins/elasticsearch', function () { | |||
| .to.have.property('settings'); | |||
| expect(params.body.settings) | |||
| .to.have.property('number_of_shards', 1); | |||
| expect(params.body.settings) | |||
There was a problem hiding this comment.
Can we update this to make sure it doesn't set the number of replicas?
expect(params.body.settings).to.not.have.property('number_of_replicas');|
jenkins, test it |
Merged
|
Failing tests |
|
Closing for #5729 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3890 removed the hard-coding of
number_of_replicasbut the change appears to have been regressed by this monster commit: 8d2e881 (by @simianhacker) which deleted one of the two (???)create_kibana_index.jsscripts and, unfortunately, not the one that #3890 modified.