Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NP] Change plugin ids to camel case #56620

Merged
merged 11 commits into from
Feb 6, 2020
Merged

[NP] Change plugin ids to camel case #56620

merged 11 commits into from
Feb 6, 2020

Conversation

maryia-lapata
Copy link
Contributor

Fixes #55363

This PR includes renaming NP plugin ids to use camel case:

  • devTools instead of dev_tools;

  • kibanaLegacy instead of kibana_legacy.

@maryia-lapata maryia-lapata added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Feb 3, 2020
flash1293
flash1293 requested changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to comment in all places, but there are too many - please only change the NP plugin id, not the feature id, role names or the route - these changes could cause backwards compatibility problems for existing clusters.

This is just about the id in the kibana.json and the property in the plugins object in setup and start contracts of consuming plugins

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@maryia-lapata
Merge remote-tracking branch 'kibana/master' into plugin-ids
971e154 
# Conflicts:
#	src/legacy/ui/public/new_platform/__mocks__/helpers.ts
@maryia-lapata maryia-lapata marked this pull request as ready for review February 5, 2020 12:57
@maryia-lapata maryia-lapata requested a review from a team February 5, 2020 12:57
@maryia-lapata maryia-lapata requested a review from a team as a code owner February 5, 2020 12:57
flash1293
flash1293 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test locally

lizozom
lizozom approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewd, but didn't test locally as well)

@maryia-lapata
Merge remote-tracking branch 'kibana/master' into plugin-ids
8744316 
# Conflicts:
#	src/legacy/core_plugins/kibana/public/dashboard/plugin.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@maryia-lapata maryia-lapata merged commit d6a500c into elastic:master Feb 6, 2020
@maryia-lapata maryia-lapata deleted the plugin-ids branch February 6, 2020 08:24
@maryia-lapata maryia-lapata mentioned this pull request Feb 6, 2020
Merged
maryia-lapata added a commit that referenced this pull request Feb 6, 2020
@maryia-lapata
[NP] Change plugin ids to camel case (#56620) (#56958)
62036cb 
* Rename dev_tools plugin id to devTools

* Fix path

* Rename kibana_legacy plugin id to kibanaLegacy

* Fix typos

* Rename plugin id to kibanaLegacy

* Revert renaming for url, route, role

* Revert changes in doc

* Update plugin.ts
@maryia-lapata maryia-lapata added backported Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@lizozom lizozom lizozom approved these changes

Assignees
No one assigned
Labels
backported Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change plugin ids to camel case
5 participants
@maryia-lapata @elasticmachine @kibanamachine @flash1293 @lizozom