-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Kibana Login Selector #53010
Changes from 12 commits
f442437
d89ab88
5253fc7
d6d4c2d
a572c52
706748a
5b189c2
db2f4b3
aae6867
1204619
181c6db
37c6489
f6b1d4f
c197b9c
aed4521
ceba57b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { LoginLayout } from './licensing'; | ||
|
||
export interface LoginSelector { | ||
enabled: boolean; | ||
providers: Array<{ type: string; name: string; description?: string }>; | ||
} | ||
|
||
export interface LoginState { | ||
layout: LoginLayout; | ||
allowLogin: boolean; | ||
showLoginForm: boolean; | ||
requiresSecureConnection: boolean; | ||
selector: LoginSelector; | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,3 +27,7 @@ | |
max-width: 700px; | ||
} | ||
} | ||
|
||
.loginWelcome__selectorButton { | ||
margin-bottom: $euiSize; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, instead of using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, I was torn on this and decided to go with CSS solution. But I don't have strong opinion here. Do we recommend using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes you can find a link to the docs in the comment above. Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, actually I use this margin for the elements that are rendered in the loop, but it seems we don't recommend using spacer in such case:
I'll see if I can turn the element I render into component. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah sorry that is an old warning. I actually have a branch going that will remove that message from our docs. It is ok to use EuiSpacer in repeatable loops. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it, replaced with |
||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: I fixed this and added tests since it looks like a bug to me?