[filter bar] Add aliasing. Closes #5194 #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like using a key on the JSON for the alias. Can we add an input field that attaches the alias to |
|
|
|
When the label set is too short, the Edit icon is no longer visible in the filter bar. This problem is actually not specific to adding aliases, even adding a filter that generates a short default description will suffer from this problem, but aliases will in particular bring this out. |
| function convertToEditableFilter(filter) { | ||
| var model = _.cloneDeep(filter); | ||
|
|
||
| var filterType; |
There was a problem hiding this comment.
This variable isn't used anymore, so you can ditch this.
|
Zooming out to less than 50% can help reproduce the issue with the icon dropping off that the last commit addresses. |
|
@jbugz confirmed the issue as fixed by the last commit. i zoomed all the way out to 25% :) LGTM |
|
LGTM |
|
Merge it! |
jbudz
added a commit
that referenced
this pull request
Nov 5, 2015
[filter bar] Add aliasing. Closes #5194
|
Super! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5194