Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure screenshot links to JUnit failures #52449

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 6, 2019

This is an effort to add failure screenshot links to the failure displays on Jenkins

@spalger spalger force-pushed the implement/failure-screenshot-link branch 9 times, most recently from 672eaf0 to 46d0b5b Compare December 9, 2019 23:45
@spalger
Copy link
Contributor Author

spalger commented Dec 10, 2019

Forced failure to test functionality:

https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/14340/

image

@spalger spalger force-pushed the implement/failure-screenshot-link branch from e56a6a2 to 095fec0 Compare December 10, 2019 16:31
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger marked this pull request as ready for review December 10, 2019 18:28
@spalger spalger requested a review from a team as a code owner December 10, 2019 18:28
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.6 v7.5.1 v7.6.0 v8.0.0 labels Dec 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger merged commit a25bf49 into elastic:master Dec 11, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Dec 11, 2019
# Conflicts:
#	src/dev/mocha/junit_report_generation.js
spalger pushed a commit to spalger/kibana that referenced this pull request Dec 11, 2019
# Conflicts:
#	packages/kbn-test/src/failed_tests_reporter/add_messages_to_report.ts
#	packages/kbn-test/src/mocha/junit_report_generation.js
@spalger spalger removed the v6.8.6 label Dec 11, 2019
spalger pushed a commit that referenced this pull request Dec 12, 2019
# Conflicts:
#	src/dev/mocha/junit_report_generation.js
spalger pushed a commit that referenced this pull request Dec 12, 2019
* Add failure screenshot links to JUnit failures (#52449)

# Conflicts:
#	packages/kbn-test/src/failed_tests_reporter/add_messages_to_report.ts
#	packages/kbn-test/src/mocha/junit_report_generation.js

* fix type error

* fix require path
@spalger
Copy link
Contributor Author

spalger commented Dec 12, 2019

7.x/7.6: 7118e48
7.5: 84667df

@spalger spalger deleted the implement/failure-screenshot-link branch December 12, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.5.1 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants