[Monitoring] h1 elements for accessibility #52276

cachedout · 2019-12-05T13:10:39Z

Add h1 headings to components in Stack Monitoring.

Refs #52275

elasticmachine · 2019-12-05T15:13:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: e35ccc4ebcce3ca733ca2b50cb3d1c157533538d

elasticmachine · 2019-12-06T14:18:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6cdd1bc4161f8fa4b702b8fcb8ef1d9e2166969e

cachedout · 2019-12-09T10:34:56Z

Hi @chrisronline I know you were looking this over the others day. Any thoughts on this approach generally? I can finish up the rest pretty quickly but just wanted a 👍 that the general approach looks good. Thanks!

chrisronline · 2019-12-09T17:01:56Z

This direction looks good to me 👍

igoristic

@cachedout Looks good 👍 One thing I noticed is that ... Overview is not always capitalized. Should we maybe keep it consistent and title case it if it's a heading?

I tested some of it with chrome accessibility and it appears to be working as expected

cachedout · 2019-12-16T17:24:46Z

Should we maybe keep it consistent and title case it if it's a heading?

Thanks, @igoristic. I've updated the PR to make capitalization more consistent.

chrisronline

Nice job overall! I left a few questions/comments

x-pack/legacy/plugins/monitoring/public/components/no_data/no_data.js

x-pack/legacy/plugins/monitoring/public/components/elasticsearch/node/node.js

…dback

cachedout · 2019-12-27T10:09:01Z

@chrisronline I wrapped up your remaining concerns this morning. Could you please take another look? Thanks!

kibanamachine · 2019-12-27T11:24:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 130d1d8

History

💚 Build #15926 succeeded 4aa7e5544e1ca718532c243d0510fda00f5a06ad
💔 Build #15822 failed aab5a6b7de95d3eaf9a87de6219fff6fea45a1bc
💔 Build #15671 failed 5b65004ef2d8ad2e74e730e5c0317337f5e557f8
💔 Build #15404 failed 0afb00b82e2c70f0bcc74e85fb530dbbfea413b4
💔 Build #15398 failed 13479ca8c57a7d2ef1b57f62d732c600fd6a65ed

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cachedout · 2020-01-02T14:35:21Z

@elasticmachine merge upstream

kibanamachine · 2020-01-02T15:49:20Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 26dcf88ef879abf1bb9a51d0900d694432d6bf3c

History

💔 Build #17325 failed 4f4ae09

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cachedout · 2020-01-03T09:31:03Z

@elasticmachine merge upstream

cachedout · 2020-01-03T11:01:46Z

@elasticmachine merge upstream

cachedout · 2020-01-03T15:09:11Z

@elasticmachine merge upstream

cachedout · 2020-01-08T12:53:21Z

@elasticmachine merge upstream

kibanamachine · 2020-01-08T14:12:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5a2e4d5

History

💔 Build #17716 failed 0030579

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cachedout · 2020-01-08T16:15:57Z

@chrisronline Given that we couldn't find a straightforward to address your review comment, I re-requested a review from you to see if you're OK with merging this as-is.

chrisronline

LGTM!

matschaffer · 2021-10-15T05:26:20Z

Just a heads up that I think this is missing a 7.x backport. I noticed when backporting #115013 (#115140) which had some conflicts on lines introduced in this PR.

Lemme know if anyone thinks we should open a backport for it at this stage or what.

* [Stack Monitoring] Fix monitoring func test (#115013) * add noDataContainer test-subj * remove unnecessary test step * Fix test subjects for overview page * remove unused service * update NoData component snapshots Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Update snaps to include items not backported from #52276 Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…gular components (#115593) (#115826) * [Stack monitoring] Remove getAngularInjector and duplicated angular components (#115593) * remove getAngularInjector and old angular components * Remove suffix from CcrShardReact component * Remove suffix from ElasticsearchOverviewReact component * Remove suffix from indexReact component * Remove suffix from NodeReact component * Remove suffix from ShardActivityReact * Remove suffix from ShardAllocationReact component and its childs * Fix import * fix translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/public/components/elasticsearch/node/node.js * Fix missing code not backported from #52276 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

estermv · 2021-10-25T10:03:18Z

I also had conflicts because of this PR in #115826

cachedout mentioned this pull request Dec 5, 2019

[Monitoring] Heading element for accessibility #52275

Closed

cachedout force-pushed the issue_37539 branch from e35ccc4 to 6cdd1bc Compare December 6, 2019 13:02

cachedout marked this pull request as ready for review December 13, 2019 14:55

cachedout requested review from chrisronline and igoristic December 13, 2019 14:55

cachedout changed the title ~~[Monitoring] [WIP] h1 elements for accessibility~~ [Monitoring] h1 elements for accessibility Dec 13, 2019

cachedout added v7.6.0 v8.0.0 release_note:enhancement labels Dec 13, 2019

cachedout force-pushed the issue_37539 branch from e8086a8 to 5b65004 Compare December 16, 2019 09:03

igoristic approved these changes Dec 16, 2019

View reviewed changes

chrisronline reviewed Dec 16, 2019

View reviewed changes

x-pack/legacy/plugins/monitoring/public/components/no_data/no_data.js Outdated Show resolved Hide resolved

x-pack/legacy/plugins/monitoring/public/components/elasticsearch/node/node.js Show resolved Hide resolved

cachedout added 13 commits December 27, 2019 09:51

Add header element to indices page for WCAG

be98129

Add h1 element for WCAG to node page

11ae391

Add h1 element for WCAG to stack monitoring overview page

f3e889e

Add h1 to advanced nodes page in stack monitoring

8d6b71c

Add h1 to nodes page in stack monitoring

fe298eb

Add h1 header for index advanced page in stack monitoring

4e46015

Standarize more on ide for h1 tag

16845ef

Give heading element to beats overview

38590fd

Update Beats listing page for H1 compat with WAVE

17853d4

Modified beat page to comply with heading rules from WCAG

f6a3b04

Kibana instance listing page updated for header WCAG

b1fee38

Add WCAG header fix to logstash listing page

dd05b78

Added headings for WCAG to logstash overview page

a64a5f0

cachedout added 2 commits December 27, 2019 10:55

Include Elasticsearch node into screen reader message, per review fee…

9e8b05e

…dback

Update snapshots

130d1d8

cachedout force-pushed the issue_37539 branch from 4aa7e55 to 130d1d8 Compare December 27, 2019 10:07

elastic deleted a comment from elasticmachine Dec 27, 2019

cachedout added 2 commits December 27, 2019 13:29

Linting

4f4ae09

Implement review suggestion for i8n compat

84b8679

Revert back to just plain string

0030579

cachedout force-pushed the issue_37539 branch from 26dcf88 to 0030579 Compare January 3, 2020 09:30

Merge branch 'master' into issue_37539

5a2e4d5

cachedout requested a review from chrisronline January 8, 2020 16:15

chrisronline approved these changes Jan 9, 2020

View reviewed changes

cachedout merged commit 459cad5 into elastic:master Jan 9, 2020

cachedout deleted the issue_37539 branch January 9, 2020 15:31

matschaffer mentioned this pull request Oct 15, 2021

[7.x] [Stack Monitoring] Fix monitoring func test (#115013) #115140

Merged

matschaffer added a commit to matschaffer/kibana that referenced this pull request Oct 15, 2021

Update snaps to include items not backported from elastic#52276

2479302

estermv added a commit to estermv/kibana that referenced this pull request Oct 21, 2021

Fix missing code not backported from elastic#52276

ef5c44c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitoring] h1 elements for accessibility #52276

[Monitoring] h1 elements for accessibility #52276

cachedout commented Dec 5, 2019

elasticmachine commented Dec 5, 2019

elasticmachine commented Dec 6, 2019

cachedout commented Dec 9, 2019

chrisronline commented Dec 9, 2019

igoristic left a comment

cachedout commented Dec 16, 2019

chrisronline left a comment

cachedout commented Dec 27, 2019

kibanamachine commented Dec 27, 2019

cachedout commented Jan 2, 2020

kibanamachine commented Jan 2, 2020

cachedout commented Jan 3, 2020

cachedout commented Jan 3, 2020

cachedout commented Jan 3, 2020

cachedout commented Jan 8, 2020

kibanamachine commented Jan 8, 2020

cachedout commented Jan 8, 2020

chrisronline left a comment

matschaffer commented Oct 15, 2021 •

edited

Loading

estermv commented Oct 25, 2021

[Monitoring] h1 elements for accessibility #52276

[Monitoring] h1 elements for accessibility #52276

Conversation

cachedout commented Dec 5, 2019

elasticmachine commented Dec 5, 2019

💔 Build Failed

elasticmachine commented Dec 6, 2019

💚 Build Succeeded

cachedout commented Dec 9, 2019

chrisronline commented Dec 9, 2019

igoristic left a comment

Choose a reason for hiding this comment

cachedout commented Dec 16, 2019

chrisronline left a comment

Choose a reason for hiding this comment

cachedout commented Dec 27, 2019

kibanamachine commented Dec 27, 2019

💔 Build Failed

History

cachedout commented Jan 2, 2020

kibanamachine commented Jan 2, 2020

💔 Build Failed

History

cachedout commented Jan 3, 2020

cachedout commented Jan 3, 2020

cachedout commented Jan 3, 2020

cachedout commented Jan 8, 2020

kibanamachine commented Jan 8, 2020

💚 Build Succeeded

History

cachedout commented Jan 8, 2020

chrisronline left a comment

Choose a reason for hiding this comment

matschaffer commented Oct 15, 2021 • edited Loading

estermv commented Oct 25, 2021

matschaffer commented Oct 15, 2021 •

edited

Loading