Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving the a11y heading issue with edit/create user #51538

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Resolving the a11y heading issue with edit/create user #51538

merged 2 commits into from
Nov 25, 2019

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Nov 22, 2019

Resolves the issue I'm still seeing with #48167

@kobelb kobelb requested a review from a team as a code owner November 22, 2019 23:19
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.6.0 labels Nov 23, 2019
jportner
jportner approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

legrego
legrego approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks for fixing!

@kobelb
Copy link
Contributor Author

kobelb commented Nov 25, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb
Copy link
Contributor Author

kobelb commented Nov 25, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb merged commit aeb082e into elastic:master Nov 25, 2019
@kobelb kobelb deleted the user-heading-a11y branch November 25, 2019 22:31
@kobelb kobelb mentioned this pull request Nov 25, 2019
Merged
kobelb added a commit to kobelb/kibana that referenced this pull request Nov 25, 2019
@kobelb
Resolving the a11y heading issue with edit/create user (elastic#51538)
d5751de
kobelb added a commit that referenced this pull request Nov 26, 2019
@kobelb
Resolving the a11y heading issue with edit/create user (#51538) (#51665)
0c23313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobelb @elasticmachine @legrego @jportner