Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NP registry instead of ui/registry/field_formats - cleanup #51419

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Use NP registry instead of ui/registry/field_formats - cleanup #51419

merged 1 commit into from
Nov 22, 2019

Conversation

alexwizp
Copy link
Contributor

Summary

Regression. Cleanup after merging #48108
Wrong import, registry/field_formats file was already removed

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp added regression v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Nov 22, 2019
@alexwizp alexwizp self-assigned this Nov 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kertal kertal self-requested a review November 22, 2019 11:00
kertal
kertal approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

@alexwizp alexwizp merged commit b5b8179 into elastic:master Nov 22, 2019
@alexwizp alexwizp mentioned this pull request Nov 22, 2019
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Nov 22, 2019
@alexwizp
Use NP registry instead of ui/registry/field_formats - cleanup (elast…
cf6304b 
…ic#51419)

Cleanup  after merging elastic#48108
alexwizp added a commit that referenced this pull request Nov 22, 2019
@alexwizp
Use NP registry instead of ui/registry/field_formats - cleanup (#51419)…
51f3f24 
… (#51433)

Cleanup  after merging #48108
@alexwizp alexwizp deleted the cleanup-48108 branch January 4, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@gospodarsky gospodarsky gospodarsky approved these changes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

@lizozom lizozom Awaiting requested review from lizozom

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees

@alexwizp alexwizp

Labels
regression release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @elasticmachine @kertal @gospodarsky