Remove @elastic/javascript-typescript-langserver #51115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
|
This was only used by the code plugin, which was removed in 7.5.0.
ecabda3 to
c6f9cd7
Compare
|
I redid this commit because the yarn file conflicted with my other package removal change that I merged. I'll do these PRs one at a time going forward to avoid duplicate reviews. |
spalger
approved these changes
Nov 20, 2019
💚 Build Succeeded |
|
I merged in the latest master just to minimize the change of any lock file wonkiness due to drift from the latest changes. No additional review is necessary unless you want to (or things blow up). |
💔 Build Failed |
|
@elasticmachine merge upstream |
💔 Build Failed |
|
It looks like the CI failure was an infra issue rather than a test failure: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/11287/execution/node/565/log/ |
|
retest |
💚 Build Succeeded |
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 21, 2019
This was only used by the code plugin, which was removed in 7.5.0.
epixa
added a commit
that referenced
this pull request
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only used by the code plugin, which was removed in 7.5.0.