Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default color on dashboard load #486

Merged
merged 1 commit into from
Sep 17, 2013

Conversation

bobrik
Copy link

@bobrik bobrik commented Sep 12, 2013

Now it works as expected :)

@rottenbytes
Copy link

upvote 👍

@bobrik
Copy link
Author

bobrik commented Sep 15, 2013

I updated it to match latest master

@mwildehahn
Copy link

👍

@rashidkpc
Copy link
Contributor

Please take a look at https://github.com/rashidkpc/kibana3/blob/master/CONTRIBUTING.md and let me know when you've completed all of the steps, then I can go ahead and merge this

@bobrik
Copy link
Author

bobrik commented Sep 16, 2013

Yep, all done. Grunt said Done, without errors.

@bobrik
Copy link
Author

bobrik commented Sep 16, 2013

Also, maybe second point in CONTRIBUTING.md should be explained with npm install && grunt.

@Seldaek
Copy link

Seldaek commented Sep 17, 2013

Am I correct in thinking this fixes the reloading of previous query colors from a saved dashboard? It drives me mad that it loses my nice error/warning/ok colors for graphs every time I reload :)

@bobrik
Copy link
Author

bobrik commented Sep 17, 2013

@Seldaek you are right :)

@Seldaek
Copy link

Seldaek commented Sep 17, 2013

OK awesome then, looking forward to seeing this merged.

@rashidkpc
Copy link
Contributor

@bobrik Have you signed the CLA? I don't see your name on the list yet.

@bobrik
Copy link
Author

bobrik commented Sep 17, 2013

Sorry about that. I just did it and got confirmation to my email.

@rashidkpc rashidkpc merged commit fc069a0 into elastic:master Sep 17, 2013
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
…godeps-mod

US16065 Add esdatalogmessage remove godeps mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants