Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security - fixing heading levels #48397

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Security - fixing heading levels #48397

merged 2 commits into from
Oct 16, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Oct 16, 2019

Fixes the following findings as reported in #48167

User management screen

  • Page must contain a level-one heading

Role management screen

  • Page must contain a level-one heading

User account screen

  • Heading levels should only increase by 1

@legrego legrego added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 labels Oct 16, 2019
@legrego legrego requested a review from myasonik October 16, 2019 12:28
@legrego legrego requested a review from a team as a code owner October 16, 2019 12:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego merged commit d26275e into elastic:master Oct 16, 2019
@legrego legrego deleted the security/a11y-headers branch October 16, 2019 15:19
@legrego legrego removed the v7.5.0 label Oct 16, 2019
legrego added a commit to legrego/kibana that referenced this pull request Oct 16, 2019
@legrego
Security - fixing heading levels (elastic#48397)
6297ae0 
* adjust heading levels

* fix heading levels on account screen
@legrego legrego mentioned this pull request Oct 16, 2019
Merged
legrego added a commit that referenced this pull request Oct 17, 2019
@legrego @elasticmachine
[7.x] Security - fixing heading levels (#48397) (#48422)
be63f1b 
* adjust heading levels

* fix heading levels on account screen

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legrego @elasticmachine @myasonik @jportner