Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to 14.4.0 #46949

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Upgrade EUI to 14.4.0 #46949

merged 3 commits into from
Oct 2, 2019

Conversation

thompsongl
Copy link
Contributor

14.4.0

  • Migrate EuiEmptyPromptand EuiCard to TS (#2387)
  • Added Lens app lensApp icon (#2389)
  • Made EuiKeyPadMenuItem beta badge smaller (#2388)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 EUI labels Sep 30, 2019
@thompsongl thompsongl requested review from snide and cchaos September 30, 2019 16:55
cchaos
cchaos approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thompsongl . LGTM once the snaps are updated.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thompsongl thompsongl marked this pull request as ready for review September 30, 2019 19:28
@thompsongl thompsongl requested review from a team as code owners September 30, 2019 19:28
@thompsongl thompsongl removed the request for review from snide September 30, 2019 19:29
legrego
legrego approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you actually need the review, but security changes LGTM!

sorenlouv
sorenlouv approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

@thompsongl
Copy link
Contributor Author

Just one very small change for @elastic/kibana-canvas code owners. Other request is just for snapshot updates.

@snide
Copy link
Contributor

snide commented Oct 2, 2019

We're merging this. I checked over the changes. They look pretty small or are snapshot related.

@thompsongl thompsongl merged commit 6f09ecc into elastic:master Oct 2, 2019
@thompsongl thompsongl mentioned this pull request Oct 3, 2019
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Oct 3, 2019
@thompsongl
Upgrade EUI to 14.4.0 (elastic#46949)
a801da3 
* eui to 14.4.0

* euicard ts updates

* snaps
thompsongl added a commit that referenced this pull request Oct 3, 2019
@thompsongl
Upgrade EUI to 14.4.0 (#46949) (#47247)
ec9c68f 
* eui to 14.4.0

* euicard ts updates

* snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@snide snide snide approved these changes

@cchaos cchaos cchaos approved these changes

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thompsongl @elasticmachine @snide @sorenlouv @cchaos @legrego