-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] i18n for page manager, page preview, and shape preview #46865
Merged
poffdeluxe
merged 7 commits into
elastic:master
from
poffdeluxe:i18n-canvas-page-related
Oct 3, 2019
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
57b4a90
i18n for page manager, page preview, and shape preview
poffdeluxe 5e04b2b
Merge branch 'master' into i18n-canvas-page-related
elasticmachine 0ef415e
Addressing feedback
poffdeluxe c476dbd
Merge branch 'master' into i18n-canvas-page-related
poffdeluxe 6e39f8e
Merge branch 'i18n-canvas-page-related' of github.com:poffdeluxe/kiba…
poffdeluxe 371d403
Forgot to remove ShapePreview
poffdeluxe fe4a828
Merge branch 'master' into i18n-canvas-page-related
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,10 @@ import React from 'react'; | |
import PropTypes from 'prop-types'; | ||
import { EuiFlexGroup, EuiFlexItem, EuiButtonIcon, EuiToolTip } from '@elastic/eui'; | ||
|
||
import { ComponentStrings } from '../../../i18n'; | ||
|
||
const { PagePreviewPageControls: strings } = ComponentStrings; | ||
|
||
export const PageControls = ({ pageId, onDelete, onDuplicate }) => { | ||
const handleDuplicate = ev => { | ||
ev.preventDefault(); | ||
|
@@ -27,15 +31,19 @@ export const PageControls = ({ pageId, onDelete, onDuplicate }) => { | |
> | ||
<EuiFlexItem grow={false}> | ||
<EuiToolTip content="Clone"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<EuiButtonIcon iconType="copy" aria-label="Clone page" onClick={handleDuplicate} /> | ||
<EuiButtonIcon | ||
iconType="copy" | ||
aria-label={strings.getClonePageAriaLabel()} | ||
onClick={handleDuplicate} | ||
/> | ||
</EuiToolTip> | ||
</EuiFlexItem> | ||
<EuiFlexItem grow={false}> | ||
<EuiToolTip content="Delete"> | ||
<EuiButtonIcon | ||
color="danger" | ||
iconType="trash" | ||
aria-label="Delete Page" | ||
aria-label={strings.getDeletePageAriaLabel()} | ||
onClick={handleDelete} | ||
/> | ||
</EuiToolTip> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,10 @@ | |
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
|
||
import { ComponentStrings } from '../../../i18n'; | ||
|
||
const { ShapePreview: strings } = ComponentStrings; | ||
|
||
interface Props { | ||
shape?: string; | ||
} | ||
|
@@ -24,7 +28,7 @@ export const ShapePreview = ({ shape }: Props) => { | |
.item(0); | ||
|
||
if (!shapeSvg) { | ||
throw new Error('An unexpected error occurred: the SVG was not parseable'); | ||
throw new Error(strings.getShapeErrorMessage()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do error messages like this need to be translated? |
||
} | ||
|
||
shapeSvg.setAttribute('fill', 'none'); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVG should be a constant?