-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify generics for IContextContainer #46538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e38f62d
to
ddcb79f
Compare
💚 Build Succeeded |
Pinging @elastic/kibana-platform |
@elasticmachine merge upstream |
ack will review tomorrow |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
mshustov
reviewed
Oct 3, 2019
mshustov
approved these changes
Oct 3, 2019
💔 Build Failed |
💚 Build Succeeded |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Oct 3, 2019
joshdover
added a commit
that referenced
this pull request
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:New Platform
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This greatly simplifies the generic types for the
IContextContainer
by leveraging more type inference and conditional types to be able to pull out all the necessary types from a single generic.Before
Before this change you had to separately define the type of the context object, the return type of the handlers, and any additional arguments provided to handlers.
After
Now, all you need to provide is the signature of the handlers:
This can be simplified even further if you already have a type defined for this:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers