Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Uptime] Move absolute date parsing to URL params hook (#46066) #46093

Merged
merged 1 commit into from
Sep 24, 2019
Merged

[7.x] [Uptime] Move absolute date parsing to URL params hook (#46066) #46093

merged 1 commit into from
Sep 24, 2019

Conversation

justinkambic
Copy link
Contributor

Backports the following commits to 7.x:

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic self-assigned this Sep 19, 2019
@justinkambic justinkambic added v7.5.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@justinkambic justinkambic changed the title [7.x] [Uptime] [Blocker] Move absolute date parsing to URL params hook (#46066) [7.x] [Uptime] Move absolute date parsing to URL params hook (#46066) Sep 19, 2019
@justinkambic justinkambic reopened this Sep 24, 2019
@justinkambic
[Uptime] [Blocker] Move absolute date parsing to URL params hook (ela…
d4bdcb9 
…stic#46066)

* Move absolute date parsing to URL params hook.

* Clean up naming.

* Update code to avoid putting dynamically-computed values in URL.

* Add test for new helper function.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit 34306fc into elastic:7.x Sep 24, 2019
@justinkambic justinkambic deleted the backport/7.x/pr-46066 branch September 24, 2019 18:30
@justinkambic justinkambic mentioned this pull request Sep 24, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc Awaiting requested review from andrewvc

Assignees

@justinkambic justinkambic

Labels
backport Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkambic @elasticmachine @andrewvc