Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose serverBasePath fixes #45991 #45995

Merged
merged 9 commits into from
Sep 30, 2019
Merged

Expose serverBasePath fixes #45991 #45995

merged 9 commits into from
Sep 30, 2019

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Sep 18, 2019

Summary

Exposes the serverBasePath

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

💔 Build Failed

@rudolf rudolf marked this pull request as ready for review September 18, 2019 13:11
@rudolf rudolf requested a review from a team as a code owner September 18, 2019 13:11
@rudolf rudolf added the release_note:skip Skip the PR/issue when compiling release notes label Sep 18, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

joshdover
joshdover approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@rudolf
Copy link
Contributor Author

rudolf commented Sep 23, 2019

@elasticmachine merge upstream

mshustov
mshustov reviewed Sep 23, 2019
View reviewed changes
src/core/server/http/base_path_service.ts Outdated
* {@link BasePath}
* @public
*/
export type BasePathContract = Pick<BasePath, keyof BasePath>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we decided on Interfaces with I-prefix usage. Didn't we?

@phillipb phillipb mentioned this pull request Sep 24, 2019
Closed
7 tasks
@rudolf rudolf requested a review from mshustov September 27, 2019 19:40
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@rudolf rudolf merged commit 08b8678 into elastic:master Sep 30, 2019
@rudolf rudolf deleted the core-http-serverbasepath branch September 30, 2019 18:49
@rudolf rudolf mentioned this pull request Sep 30, 2019
Merged
rudolf added a commit to rudolf/kibana that referenced this pull request Sep 30, 2019
@rudolf
Expose serverBasePath fixes elastic#45991 (elastic#45995)
837ee95 
* Expose serverBasePath fixes elastic#45991

* Review comments

* Fix basepath mock types

* AppBasePathContract -> IBasePath

* Match basepath test description with assertion

* Fix eslint errors
rudolf added a commit that referenced this pull request Oct 1, 2019
@rudolf
Expose serverBasePath fixes #45991 (#45995) (#46966)
1e2f6d8 
* Expose serverBasePath fixes #45991

* Review comments

* Fix basepath mock types

* AppBasePathContract -> IBasePath

* Match basepath test description with assertion

* Fix eslint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin left review comments

@joshdover joshdover joshdover approved these changes

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rudolf @elasticmachine @azasypkin @joshdover @mshustov