Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove injectI18n in management. #45876

Merged
merged 12 commits into from
Oct 8, 2019
Merged

Remove injectI18n in management. #45876

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e97b96e
Prettierize.
sainthkh Sep 17, 2019
cf39fe7
Removed injectI18n.
sainthkh Sep 18, 2019
1f947bc
Fixed Field.js and its tests.
sainthkh Sep 18, 2019
a453be8
Fixed eslint error.
sainthkh Oct 3, 2019
a61f529
Revert "Fixed Field.js and its tests."
sainthkh Sep 18, 2019
9be6d69
Fixed simple tests.
sainthkh Oct 3, 2019
b6f0f77
Fixed other tests.
sainthkh Oct 3, 2019
26eadbe
Fixed x-pack snapshot error.
sainthkh Oct 3, 2019
714029b
TableComponent to Table
mattkime Oct 4, 2019
f553e47
Merge branch 'master' into management-i18n
mattkime Oct 7, 2019
04cefeb
Fixed eslint error.
sainthkh Oct 8, 2019
5ee00f1
Merge remote-tracking branch 'upstream/master' into management-i18n
sainthkh Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ..._patterns/edit_index_pattern/indexed_fields_table/components/table/__jest__/table.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import React from 'react';
import { shallow } from 'enzyme';
import { shallowWithI18nProvider } from 'test_utils/enzyme_helpers';

import { TableComponent } from '../table';
import { Table } from '../table';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


const indexPattern = {
timeFieldName: 'timestamp'
Expand All @@ -36,7 +36,7 @@ const items = [
describe('Table', () => {
it('should render normally', async () => {
const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={() => {}}
Expand All @@ -48,7 +48,7 @@ describe('Table', () => {

it('should render normal field name', async () => {
const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={() => {}}
Expand All @@ -61,7 +61,7 @@ describe('Table', () => {

it('should render timestamp field name', async () => {
const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={() => {}}
Expand All @@ -74,7 +74,7 @@ describe('Table', () => {

it('should render the boolean template (true)', async () => {
const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={() => {}}
Expand All @@ -87,7 +87,7 @@ describe('Table', () => {

it('should render the boolean template (false)', async () => {
const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={() => {}}
Expand All @@ -100,7 +100,7 @@ describe('Table', () => {

it('should render normal type', async () => {
const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={() => {}}
Expand All @@ -113,7 +113,7 @@ describe('Table', () => {

it('should render conflicting type', async () => {
const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={() => {}}
Expand All @@ -128,7 +128,7 @@ describe('Table', () => {
const editField = jest.fn();

const component = shallowWithI18nProvider(
<TableComponent
<Table
indexPattern={indexPattern}
items={items}
editField={editField}
Expand Down