Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent space identifier url example from overflowing panel #44871

Merged
merged 4 commits into from
Sep 5, 2019
Merged

Prevent space identifier url example from overflowing panel #44871

merged 4 commits into from
Sep 5, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Sep 5, 2019

Summary

Fixes #44849

image

@legrego legrego added release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Spaces Platform Security - Spaces feature v8.0.0 v7.4.0 v7.5.0 labels Sep 5, 2019
@legrego legrego requested a review from a team as a code owner September 5, 2019 11:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@legrego legrego requested review from kobelb and azasypkin September 5, 2019 12:00
@azasypkin
Copy link
Member

ACK: reviewing now. Btw, looks like we need to update Jest snapshot @legrego

azasypkin
azasypkin approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and everything looks good, thanks! As we discussed over slack we may need to file EUI issue related to the way EUI inputs ^handles^ with very long non-ASCII strings.

@legrego legrego removed the request for review from kobelb September 5, 2019 13:10
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego merged commit 1a15d5b into elastic:master Sep 5, 2019
@legrego legrego deleted the spaces/max-id-length branch September 5, 2019 14:06
This was referenced Sep 5, 2019
Merged
Merged
legrego added a commit to legrego/kibana that referenced this pull request Sep 5, 2019
@legrego
Prevent space identifier url example from overflowing panel (elastic#…
6b355bc 
…44871)

* ensure example url wraps properly when the space identifier is long

* restrict space identifier length to 500 characters

* Revert "restrict space identifier length to 500 characters"

This reverts commit a34f324.

* update snapshot
@legrego legrego mentioned this pull request Sep 5, 2019
Closed
legrego added a commit that referenced this pull request Sep 5, 2019
@legrego
Prevent space identifier url example from overflowing (#44871) (#44888)
f49c6bf 
* ensure example url wraps properly when the space identifier is long

* restrict space identifier length to 500 characters

* Revert "restrict space identifier length to 500 characters"

This reverts commit a34f324.

* update snapshot
legrego added a commit that referenced this pull request Sep 5, 2019
@legrego
Prevent space identifier url example from overflowing (#44871) (#44889)
66db4ad 
* ensure example url wraps properly when the space identifier is long

* restrict space identifier length to 500 characters

* Revert "restrict space identifier length to 500 characters"

This reverts commit a34f324.

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
Feature:Security/Spaces Platform Security - Spaces feature release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit the number of characters while creating a space
3 participants
@legrego @elasticmachine @azasypkin