Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] call process.exit() on task complete #44092

Merged
merged 1 commit into from
Aug 27, 2019
Merged

[i18n] call process.exit() on task complete #44092

merged 1 commit into from
Aug 27, 2019

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Aug 27, 2019 •
edited
Loading

call process.exit() on i18n_extact complete. this ensures the process closes when spawned from a child process.

Needed when running translation scripts in this repo: https://github.com/elastic/translations

@Bamieh
Update run_i18n_extract.ts
1998e2d 
call `process.exit()` on `i18n_extact` complete. this ensures the process closes when spawned from a child process.
@Bamieh Bamieh added Project:i18n v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 labels Aug 27, 2019
@Bamieh Bamieh requested a review from bmcconaghy August 27, 2019 13:30
@Bamieh Bamieh requested a review from a team as a code owner August 27, 2019 13:30
bmcconaghy
bmcconaghy approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jbudz
jbudz approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - was it removed by accident?

@Bamieh
Copy link
Member Author

Bamieh commented Aug 27, 2019

@jbudz its not needed when running it directly by calling node scripts/i18n_extract.js as the process exits normally. But it seems to only hang if it was called from a child_process.spawn so this attempts to solve it.

@Bamieh Bamieh merged commit cb17672 into master Aug 27, 2019
@Bamieh Bamieh deleted the i18n]-process-exit-on-complete branch August 27, 2019 21:46
This was referenced Aug 27, 2019
Merged
Merged
Bamieh added a commit to Bamieh/kibana that referenced this pull request Aug 27, 2019
@Bamieh
Update run_i18n_extract.ts (elastic#44092)
8729813 
call `process.exit()` on `i18n_extact` complete. this ensures the process closes when spawned from a child process.
Bamieh added a commit to Bamieh/kibana that referenced this pull request Aug 27, 2019
@Bamieh
Update run_i18n_extract.ts (elastic#44092)
14e4bdc 
call `process.exit()` on `i18n_extact` complete. this ensures the process closes when spawned from a child process.
Bamieh added a commit that referenced this pull request Aug 28, 2019
@Bamieh
Update run_i18n_extract.ts (#44092) (#44177)
a4287db 
call `process.exit()` on `i18n_extact` complete. this ensures the process closes when spawned from a child process.
Bamieh added a commit that referenced this pull request Aug 28, 2019
@Bamieh
Update run_i18n_extract.ts (#44092) (#44176)
8b2147e 
call `process.exit()` on `i18n_extact` complete. this ensures the process closes when spawned from a child process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcconaghy bmcconaghy bmcconaghy approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
Project:i18n release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bamieh @elasticmachine @bmcconaghy @jbudz